Skip to content

Fix link bugs and add style improvements. - #175

Merged
zpChris merged 4 commits into
mainfrom
LinkBugFixes
Jul 3, 2021
Merged

Fix link bugs and add style improvements.#175
zpChris merged 4 commits into
mainfrom
LinkBugFixes

Conversation

@zpChris

@zpChriszpChris commented Jun 27, 2021

Copy link
Copy Markdown
Contributor

List of Changes:

  • Update the "Create a problem" link on the "Verified Problems" page to the correct url: /problem/create.
  • Update problem to only be set initially once.
  • Update Back button to return to previous page only if one exists on the same site; otherwise, go to the dashboard.
  • Restrict the problem description line length to one line.

Notes:

  • The problem must be set only initially once because every time it is set, a new id is given for each test case; this means that the JSON.stringify check on the Back button will sometimes return that the problem was updated, even when it was not.
  • I found the Back button "POP" check at this Stack Overflow post.
  • An explanation / demonstration of the line length clamp is shown at this screencast (albeit on another page, but still relevant).

Screencast and Images:

Screencast of the Fix Link Bugs and Update Site Design

Update Description Length on Verified Problems
This image just shows one small portion of the PR.
Update Description Length on Verified Problems

@zpChriszpChris added frontend design Improvement to frontend design labels Jun 27, 2021
@zpChris

Copy link
Copy Markdown
ContributorAuthor

@zpChris
zpChris requested a review from alankbiJune 28, 2021 00:23

@alankbialankbi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left one comment about potentially reusing the line camp component (nice find btw 🙂), but otherwise should be good to merge whenever ready

Comment threadfrontend/src/components/card/ProblemCard.tsx Outdated
@alankbi

Copy link
Copy Markdown
Contributor

Also, lmk if you planned on setting the min-width on this or another PR and I can take a look at that as well (it's a small change though so prob would be fine with just merging that without additional review)

@zpChris

Copy link
Copy Markdown
ContributorAuthor

Also, lmk if you planned on setting the min-width on this or another PR and I can take a look at that as well (it's a small change though so prob would be fine with just merging that without additional review)

I'll likely do this on another PR with a list of other small changes 👍

@zpChris
zpChris merged commit 5389da0 into mainJul 3, 2021
@zpChris
zpChris deleted the LinkBugFixes branch July 3, 2021 22:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

designImprovement to frontend designfrontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zpChris@alankbi