Uh oh!
There was an error while loading. Please reload this page.
Roflex dev branch - #27
Open
Hugheth wants to merge 23 commits into
Open
Conversation
…Allow all operators to be overridden
…ting toString and equals
ckdavid
suggested changes
May 24, 2019
| ]] | ||
| function AsyncUtils.props(things) | ||
| local keys = TableUtils.keys(things) | ||
| local values = |
Contributor
There was a problem hiding this comment.
What's the idea of using this instead of TableUtils.values?
| for _, key in ipairs(keys) do | ||
| local value = instance[key] | ||
| if not first then | ||
| string = string .. ", " |
Contributor
There was a problem hiding this comment.
Couldn't you just table.concat the k=v pairs together?
| return string .. ")" | ||
| end | ||
| function ClassUtils.makeClass(name, constructor, include) |
Contributor
There was a problem hiding this comment.
What does include mean? Name and constructor are pretty obvious, but I think include could do with a comment explaining what is it (and maybe a better name - useDefaults?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.