Skip to content

Add bucket region for web - #606

Merged
Myztiq merged 1 commit into
masterfrom
add-aws-region-to-fe
Mar 1, 2017
Merged

Add bucket region for web#606
Myztiq merged 1 commit into
masterfrom
add-aws-region-to-fe

Conversation

@thejsj

Copy link
Copy Markdown
Member

What this PR does

  • Adds AWS_REGION ENV to web
  • Add aws region for delta (us-west-2)

Deployment (post-merge)

Ensure that all environments have the given changes.

  • deployed to gamma
  • deployed to delta

Comment threadansible/.npmrc Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in here?

@thejsj
thejsjforce-pushed the add-aws-region-to-fe branch from e4e09e2 to e6450f4CompareMarch 1, 2017 21:58

@MyztiqMyztiq left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"MIXPANEL_PROXY_URL {{ mixpanel_proxy_url }}",
"AWS_ACCESS_KEY {{ aws_access_key }}",
"AWS_BUCKET app.{{ domain }}",
"AWS_REGION {{ web_aws_bucket_region | default('us-standard') }}",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why us-standard as default?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the default region and what we use for gamma.

@Myztiq
Myztiq merged commit 662dcd8 into masterMar 1, 2017
@Myztiq
Myztiq deleted the add-aws-region-to-fe branch March 1, 2017 22:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thejsj@podviaznikov@Myztiq@anandkumarpatel