Uh oh!
There was an error while loading. Please reload this page.
Added keymaker configurations. - #666
Merged
Merged
Conversation
tosih
requested changes
May 17, 2017
| # keymaker | ||
| keymaker_pg_database: keymaker | ||
| keymaker_port: 7788 |
Author
There was a problem hiding this comment.
nope, since it's in kubernetes, the port doesn't matter anymore! Woooo
Member
There was a problem hiding this comment.
Can we at least change it to avoid conflicts for local dev? For example, when port forwarding.
There was a problem hiding this comment.
you have this in .env of keymaster: PORT=3008
anandkumarpatel
requested changes
May 17, 2017
| value: "{{ keymaker_pg_pass }}" | ||
| - name: PGHOST | ||
| value: "{{ pg_host }}" | ||
| - name: PGPORT |
There was a problem hiding this comment.
do you need this and the above PG*? you have the whole string below?
| - group_vars/alpha-keymaker-base.yml | ||
| - group_vars/alpha-keymaker-worker.yml | ||
| roles: | ||
| - role: builder |
There was a problem hiding this comment.
remove builder here, no need to build 2 times :)
Author
There was a problem hiding this comment.
Sadly, untrue, builder pushes the image to the remote and it's a different name, keymaker-worker vs keymaker-http
anandkumarpatel
approved these changes
May 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added keymaker configurations