Skip to content

Stop using outdated feature gates - #31

Merged
CodeSandwich merged 3 commits into
CodeSandwich:masterfrom
rye:no-use_extern_macros
Feb 9, 2019
Merged

Stop using outdated feature gates#31
CodeSandwich merged 3 commits into
CodeSandwich:masterfrom
rye:no-use_extern_macros

Conversation

@rye

@ryerye commented Dec 23, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

This feature was stabilized in Rust 1.30.0?

See rust-lang/rust#50911, and the release notes for 1.30.0 which include that PR.

See also rust-lang/rust@d3c902f, which merged the proc_macro_* macros into one proc_macro_hygiene feature gate.

@rye
Stop using #![feature(use_extern_macros)]
2afa501
This is done because it was stabilized in 1.30.
@CodeSandwich

CodeSandwich commented Dec 24, 2018

Copy link
Copy Markdown
Owner

Hi @rye,
Thank you for contributing! This looks like a good change, I'll test it after Christmas. I think I'll bump a major version before releasing, because it breaks compatibility with older compiler versions.

@rye

rye commented Dec 24, 2018

Copy link
Copy Markdown
ContributorAuthor

@CodeSandwich, sounds good!

I have also noticed that this project is using the proc_macro_gen and proc_macro_mod features, which have been removed and replaced by proc_macro_hygiene… that is what is breaking the Travis nightlies, I might add.

Should I update those in this PR as well? I can also make another one.

@CodeSandwich

CodeSandwich commented Dec 24, 2018

Copy link
Copy Markdown
Owner

Oh, you're right, the CI got worse. I've stopped paying attention to the error messages and the went from single failing test to compilation failure. Of course, if you have time, please add fix to this as well, that's very much appreciated.

@rye
tests/injecting: Combine proc_macro_gen and proc_macro_mod features
f9c8774
See commit d3c902f3113575b134641c14a9734b5075d06b09 in rust-lang/rust,
which was released in version 1.30.0. (I think.)
Cleans up a bunch of `cargo test` errors and allows CI to actually run.
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@ryerye changed the title Stop using #![feature(use_extern_macros)]Stop using outdated feature gatesDec 24, 2018
@rye
lib: Update documentation example for proc_macro_mod inclusion?
5ba3838
I'm not even sure we need this, but since this feature gate hasn't been
stabilized I guess we still need this. (If I remove #![feature(proc_macro_hygiene)]
from the tests, the builds go red.)
Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@rye

rye commented Dec 28, 2018

Copy link
Copy Markdown
ContributorAuthor

@CodeSandwich, just so you know I went ahead and update the usage of proc_macro_* to match the new nightly gates. Let me know if I can be of any further assistance!

@CodeSandwich

CodeSandwich commented Jan 2, 2019

Copy link
Copy Markdown
Owner

I'm very sorry, but since a few days and for a few more I will not be able to work on Mocktopus. I will gladly come back to coding, reviewing and discussing when my personal situation gets a bit more stable and less time consuming.

@CodeSandwich
CodeSandwich merged commit 5ba3838 into CodeSandwich:masterFeb 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rye@CodeSandwich