Skip to content

[Feature] Implement logout function - #42

Merged
saseungmin merged 1 commit into
CodeSoom:mainfrom
saseungmin:use-localstorage-and-logout
Nov 29, 2020
Merged

[Feature] Implement logout function#42
saseungmin merged 1 commit into
CodeSoom:mainfrom
saseungmin:use-localstorage-and-logout

Conversation

@saseungmin

@saseungminsaseungmin commented Nov 29, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator
  • with firebase auth and redux
  • change header status with localstorage

loginlogout

@saseungmin
[Feature] Implement logout function
434d318
- with firebase auth and redux
- change header status
@saseungminsaseungmin added the enhancement New feature or request label Nov 29, 2020
saseungmin
saseungmin commented Nov 29, 2020
View reviewed changes
Comment threadsrc/components/common/Header.jsx
{user ? (
<div>
<button type="button">로그아웃</button>
<span>{user}</span>

@saseungminsaseungminNov 29, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 지금은 사용자의 이메일을 헤더에 나타나는데 회원가입할 때 사용자의 이름도 같이 입력받아서 이름으로 나타내도 좋을거 같다.

@saseungmin

saseungmin commented Nov 29, 2020

Copy link
Copy Markdown
CollaboratorAuthor
  • 로그인 회원가입시 validation 체크가 아직 되어있지 않다. (추후 구현해주기)

@saseungmin
saseungmin merged commit 8ed8ba8 into CodeSoom:mainNov 29, 2020
@saseungminsaseungmin mentioned this pull request Nov 29, 2020
Closed
20 tasks
@saseungmin
saseungmin deleted the use-localstorage-and-logout branch July 5, 2021 19:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@saseungmin