Added defeat/grind conditions - #89
Conversation
Split some temple regions to accomodate for defeat logic: open4.6 -> open4.6 / open4.6.5 open7.2 -> open7.1.5 / open7.2 open7.5 -> open7.4.5 / open7.5 zirvitar was basically redone entirely and I'm gonna move the chests and cutscenes so it makes sense
reworked the kajo regions
Had to draw all the regions again to accomodate the changes
CodeTriangle
left a comment
There was a problem hiding this comment.
Did a quick check over the changes. Am interested to hear your thoughts.
| "Cold", | ||
| 1 | ||
| ] | ||
| ["defeat", "Neutral Virus", "Heat Virus", "Cold Virus"] |
There was a problem hiding this comment.
I wonder about turning this into region along with Wasteland: Spiral Cliff Center. Usually a region with 2 locations would seem spurious, but it might be good for a condition that takes so long to check. What are your thoughts?
| [ "or", | ||
| [ "grind", "Young Frobbit" ], | ||
| [ "grind", "White Frobbit" ] | ||
| ] |
There was a problem hiding this comment.
I wonder about the correct way to do or conditions. To cut down on individual grind calls, maybe it could be helpful to have a ["grindAny", ...] condition that indicates that you must be able to kill at least one of the given enemies, if you think that would be helpful?
There was a problem hiding this comment.
That would certainly make some things simpler yeah. It's not required for that many quests, but it would make things simpler. It would also be extremely useful for when we implement tradesanity.
There was a problem hiding this comment.
As a point of order, when we implement tradesanity I was actually thinking we'd do it with a new kind of condition, where the trade would specify a list of items required, and then there would be another file that associates items with conditions to get those items.
There was a problem hiding this comment.
Gotcha. Still would be useful to have that for the item conditions.
| "condition": [[ "region", "open", "open10.Grove" ]], | ||
| "condition": [ | ||
| [ "region", "open", "open10.Grove" ], | ||
| [ "defeat", "Tunnel Gelleric", "Tunnel Argeby", "Tunnel Angler" ] |
There was a problem hiding this comment.
I actually don't think the Tunnel enemies are in the data.
There was a problem hiding this comment.
If you mean in the crosscode data files, I found them under enemies/jungle/special/quest_td_X.json
There was a problem hiding this comment.
Nah, in the CCMWR files, in data/in/{dlc/,}enemies.json. That's where the conditions for acquiring each enemy are.
CodeTriangle
commented
Aug 1, 2026
Also, it seems you aren't finished. Could you convert this PR into a draft until you're ready for it to be merged? |
Added conditions to all chests, quests, cutscenes, with the exception of dungeon regions and chests because of potential upcoming changes to those that would mean having to redo all of it.