Skip to content

WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 2 | Improve code with precomputing - #201

Open
JanefrancessC wants to merge 2 commits into
CodeYourFuture:mainfrom
JanefrancessC:precompute
Open

WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 2 | Improve code with precomputing#201
JanefrancessC wants to merge 2 commits into
CodeYourFuture:mainfrom
JanefrancessC:precompute

Conversation

@JanefrancessC

@JanefrancessCJanefrancessC commented Jul 1, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Improved the code with precomputing

@JanefrancessCJanefrancessC added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Jul 1, 2026
cjyuan
cjyuan reviewed Jul 2, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Could you use complexity to show how much improvement have been made?

@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 2, 2026
@JanefrancessC

JanefrancessC commented Jul 6, 2026

Copy link
Copy Markdown
Author

Code looks good.

Could you use complexity to show how much improvement have been made?

Thanks. I've included complexity analysis as comments to the code.

@JanefrancessCJanefrancessC added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026
cjyuan
cjyuan reviewed Jul 6, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@cjyuancjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuancjyuancjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-ComplexityThe name of the module.📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JanefrancessC@cjyuan