London | 26-ITP-May | Jorvan White | Sprint 2 | Book library by JorvanW · Pull Request #548 · CodeYourFuture/Module-Data-Flows

JorvanW · 2026-08-13T14:31:31Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Created Pull Request from Data Flows Book Library Task

… and made sure it can produce error with not inputting author

cjyuan

Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Flows/blob/general-review-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

JorvanW · 2026-08-16T18:29:30Z

I think I have made some relevant changes following the link given

cjyuan · 2026-08-16T18:32:24Z

+ <button
+ type="button"
+ class="btn btn-primary"
+ onclick="submit();"


Could you look up the trade-off between:
Assigning event listener in HTML
Assigning event listener in JS via .addEventListener()

cjyuan · 2026-08-16T18:38:31Z

 } else {
- let book = new Book(title.value, title.value, pages.value, check.checked);
-library.push(book);
+ let book = new Book(title.value, author.value, pages.value, check.checked);


What if user enter title as " C++ Programming ", and page count as "30e1", "00030", or "12.345"?

user is no longer able to input anything in page count that isn't a whole positive number

… instead clear all at once

…the book delete before the alert message is passed

JorvanW · 2026-08-17T15:41:01Z

I have made relevant changes from the comments given. Please let me know if there are other issues to work on.

JorvanW · 2026-08-17T15:42:00Z

At the time of writing this, I believe github is down and causing some problem with loading

cjyuan · 2026-08-17T20:08:04Z

Changes are good. Could you also address the remaining three "unresolved" comments left in my previous review? Two of which are related to index.html, and the 3rd one is related to handling of user input.

JorvanW · 2026-08-18T11:00:21Z

Hello, I could be wrong but I have addressed these comments that are not resolved yesterday but because github was down they weren't synced properly. Please let me know if there are still mistakes I have overlooked in case its a fault on my end. Many Thanks

cjyuan · 2026-08-18T12:09:36Z

You could verify if the changes made on this branch is up to date:

Click the "Commits" tab to see all the commits
Click the "Files changed" tab to see the content of the changed files.

JorvanW · 2026-08-18T13:51:57Z

fixed changes mentioned from comments

cjyuan

Changes look good.

cjyuan · 2026-08-18T14:06:37Z

+const bookForm = document.getElementById("bookForm");
+const bookTableBody = document.getElementById("bookTableBody");
+
+submitButton.addEventListener("click", submit);


Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.
This makes it easier to locate and manage all the code that runs once when the app starts.

JorvanW added 2 commits August 13, 2026 15:03

made changes to the script.js to fix the issues with the library site…
c65e2e0
… and made sure it can produce error with not inputting author

added more small changes
910705e

This comment has been minimized.
Sign in to view

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2026

cjyuan reviewed Aug 13, 2026
View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2026

JorvanW added 2 commits August 15, 2026 18:09

fixed formatting errors on book-library
ecf8d3b

Removed more unnecessary sections of my code
20e44ff

JorvanW added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 16, 2026

removed (e) from window.addEventListener
eb05054

cjyuan reviewed Aug 16, 2026
View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 16, 2026

JorvanW added 10 commits August 17, 2026 15:32

updated html and js to only accept whole positive numbers
fff78c6

switched event listener from html to javascript
9309180

changed myLibrary declaration to const to not get reassigned
ac0932c

removed .value = null and replace == t0 ===
41c6298

simplified code by using bookForm.reset
b9bd1fe

updated the js to reject various number combinations for page inputs
214517b

updated js and html to no longer delete every table one by one but to…
5873142
… instead clear all at once

cleaned up some code and removed id attribute
53cde05

fixed errors stopping page from loading
165351f

reorder sequence of delete button and added timeout function to make …
641cfe0
…the book delete before the alert message is passed

JorvanW added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 17, 2026

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 17, 2026

JorvanW added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 18, 2026

JorvanW mentioned this pull request Aug 18, 2026
26-ITP-MAY | Data flows | Jorvan White JorvanW/My-Coursework-Planner#35
Open

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 18, 2026

JorvanW added 2 commits August 18, 2026 14:21

fixed min value in input tag and trimmed author and title values
64c48cb

fixed eventListenter and get button details
e52b152

JorvanW added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 18, 2026

cjyuan reviewed Aug 18, 2026
View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 18, 2026

Uh oh!

Uh oh!

Conversation

JorvanW commented Aug 13, 2026

Changelist

Uh oh!

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

JorvanW commented Aug 16, 2026

Uh oh!

Uh oh!

cjyuanAug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuanAug 16, 2026

Choose a reason for hiding this comment

Uh oh!

JorvanWAug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorvanW commented Aug 17, 2026

Uh oh!

JorvanW commented Aug 17, 2026

Uh oh!

cjyuan commented Aug 17, 2026

Uh oh!

JorvanW commented Aug 18, 2026

Uh oh!

cjyuan commented Aug 18, 2026

Uh oh!

JorvanW commented Aug 18, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuanAug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants