Skip to content

London | 26-ITP-May | Edina Kurdi | Sprint 3 | Programmer Humour - #555

Open
edinakurdi wants to merge 9 commits into
CodeYourFuture:mainfrom
edinakurdi:feature/xkcd
Open

London | 26-ITP-May | Edina Kurdi | Sprint 3 | Programmer Humour#555
edinakurdi wants to merge 9 commits into
CodeYourFuture:mainfrom
edinakurdi:feature/xkcd

Conversation

@edinakurdi

@edinakurdiedinakurdi commented Aug 14, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • set up html, css and js files
  • implemented fetchData using fetch and async/await
  • logged the json data to the console
  • rendered the img (wth title, and alt) into the DOM
  • added try...catch and http status error handling
  • added basic css styling with a centered teal theme

@edinakurdiedinakurdi added 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 14, 2026
@hey-hammadhey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 25, 2026
hey-hammad
hey-hammad suggested changes Aug 25, 2026
View reviewed changes

@hey-hammadhey-hammad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall! Just one minor code-quality improvement needed. Thanks

Comment threadfetch/programmer-humour/script.js
@@ -0,0 +1,35 @@
const endpointAPI = "https://xkcd.now.sh/?comic=latest";

@hey-hammadhey-hammadAug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpointAPI is used both outside and inside the function. This can be confusing, so Its best to rename the function parameter to make the code clearer and avoid shadowing.

more on shadowing here:
https://www.geeksforgeeks.org/javascript/variable-shadowing-in-javascript/

@edinakurdiedinakurdiAug 26, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now corrected. thank you

@hey-hammadhey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 25, 2026
@edinakurdiedinakurdi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hey-hammadhey-hammadhey-hammad requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Module-Data-FlowsThe name of the module.Needs ReviewTrainee to add when requesting review. PRs without this label will not be reviewed.🏕 Priority MandatoryThis work is expected📅 Sprint 3Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edinakurdi@hey-hammad