Skip to content

London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book Library#569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandipsanger wants to merge 10 commits into
base:main
Choose a base branch
from
Open

London | 26-ITP-May | Mandip Sanger | Sprint 2 | Book Library #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
97c6d21
book lilbrary fix bug
mandipsanger Aug 20, 2026
16fa264
book library debugging
mandipsanger Aug 20, 2026
3013701
fix changes
mandipsanger Aug 20, 2026
597ab64
adding file
mandipsanger Aug 20, 2026
291e346
adding relevant files
mandipsanger Aug 20, 2026
8bf9a93
adding files
mandipsanger Aug 20, 2026
269f218
adding title to html
mandipsanger Aug 20, 2026
e686370
fixing validation issue
mandipsanger Aug 21, 2026
10d0aba
response to feedback
mandipsanger Aug 21, 2026
030e4f9
changes
mandipsanger Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 64 additions & 51 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,23 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title> </title>
<title>The Book Library</title>

<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>

<link rel="stylesheet" type="text/css" href="style.css" />
</head>

Expand All@@ -23,51 +27,67 @@ <h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
<button
data-toggle="collapse"
data-target="#demo"
class="btn btn-info"
type="button"
>
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<form id="form">
<div class="form-group">
<!-- Title -->
<label for="title">Title:</label>
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="text"
class="form-control"
id="title"
name="title"
required
/>

<!-- Author -->
<label for="author">Author:</label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>

<!-- Pages -->
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
step="1"
required
/>

<!-- Read -->
<div class="form-check">
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
name="read"
/>
Read
</label>
</div>

<!-- Submit -->
<button type="submit" class="btn btn-primary">Submit</button>
</div>
</form>
</div>

<table class="table" id="display">
Expand All@@ -80,15 +100,8 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>

<tbody id="book-list"></tbody>
</table>

<script src="script.js"></script>
Expand Down
166 changes: 101 additions & 65 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,78 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readInput = document.getElementById("check");
const form = document.getElementById("form");

window.addEventListener("load", function () {
populateStorage();
render();

if (form) {
form.addEventListener("submit", function (event) {
event.preventDefault();
submit();
});
}
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
if (myLibrary.length === 0) {
// Initialize sample data with two books
myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true));

myLibrary.push(
new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true)
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
// Get cleaned input values
const titleValue = titleInput.value.trim();
const authorValue = authorInput.value.trim();
const pagesValue = pagesInput.value.trim();

// Check for empty input fields
if (!titleValue || !authorValue || !pagesValue) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}

// Make sure pages contains digits only
if (!/^\d+$/.test(pagesValue)) {
alert("Number of pages needs to be a valid integer greater than 0!");
return;
}

// Convert pages to a number
const pageNumber = Number(pagesValue);

// Check that pages is greater than zero
if (pageNumber <= 0) {

@cjyuancjyuanAug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Could also consider using Number.isInteger() on line 54 instead of using regular expression on line 45.

alert("Number of pages needs to be a valid integer greater than 0!");
return;
}

// Create a new book using cleaned and validated values
const newBook = new Book(
titleValue,
authorValue,
pageNumber,
readInput.checked
);

// Add the new book
myLibrary.push(newBook);

// Update the display
render();

// Reset the entire form
if (form) {
form.reset();
}
}

Expand All@@ -51,53 +84,56 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
const table = document.getElementById("display");
const rowsNumber = table.rows.length;

// Remove existing rows except header
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
Comment on lines +91 to 93

@cjyuancjyuanAug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look up a more efficient approach (than deleting table rows one by one) to clear the <tbody> part of a table?

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;

for (let i = 0; i < myLibrary.length; i++) {
const row = table.insertRow();

// Insert book information
row.insertCell().innerText = myLibrary[i].title;
row.insertCell().innerText = myLibrary[i].author;
row.insertCell().innerText = myLibrary[i].pages;

// Read/Unread button
const readCell = row.insertCell();

const changeBut = document.createElement("button");
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
changeBut.innerText = myLibrary[i].check ? "Yes" : "No";

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
readCell.appendChild(changeBut);

// Delete button
const deleteCell = row.insertCell();

const delBut = document.createElement("button");
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
delBut.innerText = "Delete";

delBut.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;

// Delete the book first
myLibrary.splice(i, 1);

// Update the display
render();

// Show confirmation after deletion
alert(`You've deleted title: ${deletedTitle}`);
});

deleteCell.appendChild(delBut);
}
}
2 changes: 1 addition & 1 deletion debugging/book-library/style.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,5 +15,5 @@
}

button.btn-info {
margin: 20px;
margin: 30px;
}
Loading