London | 26-ITP-May | Damilola Odumosu | Sprint 1 | Coursework by d-odumosu · Pull Request #1296 · CodeYourFuture/Module-Data-Groups

d-odumosu · 2026-07-26T15:24:48Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Sprint 1 Tasks

fix :

median

implement:

dedupe
max
sum

refactor:

includes

… of loop. all tests pass.

cjyuan · 2026-07-31T15:50:03Z

+ if (elementLists.length === 0) {
+ return undefined;
+ }


When a function is expected to return a number, it is better to design the function to always returned a value of type number for consistency.
Technically, an empty array also an array containing no numbers.

fixed to return 0

What's your decision process to select 0 as the return value when an array does not contain any numbers?

since the function is supposed to return a number i thought it best that if the array is empty /contain to numbers it should return 0

An empty array is also an array containing no numbers. So the function could also return the same value in both cases. However, if the function needs to distinguish an empty array from an array containing no numbers, then your choice would make sense.

cjyuan · 2026-07-31T15:55:27Z

+ let sum = 0;
+ for (let i = 0; i < elementsList.length; i++) {
+ sum += elementsList[i];
+ }
+ return sum;


Could this code work for an array of any length?

yes, so i think i dont have to check and return 0 if its empty because the loop will do that anyway, thank you, fixed

You also don't have to check if the array length is 1.

yes, removed this

cjyuan · 2026-08-21T15:29:35Z

 if (elements.length === 0) {
 return [];
 }

- return elements.filter((item, index) => elements.indexOf(item) === index);
+ return [...new Set(elements)];


Using Set() also works. The point I wanted to make was, checking elements.length === 0 is optional.

cjyuan · 2026-08-21T15:31:10Z

 testCaseNoDuplicates.forEach(({ input, expected }) => {
 test("given an array with no duplicates, return a copy of the array", () => {
 expect(dedupe(input)).toEqual(expected);
+ expect(result).not.toBe(input);


What is result?

result saves the function call of dedeupe

Is result declared and assigned any value?

yes i see the problem now, i have fixed it

cjyuan · 2026-08-21T15:36:01Z

+ if (elementLists.length === 0) {
+ return undefined;
+ }


What's your decision process to select 0 as the return value when an array does not contain any numbers?

cjyuan · 2026-08-21T15:40:44Z

 const elementsList = elements.filter((element) => {
- return typeof element === "number";
+ return (
+ typeof element === "number" &&
+ !Number.isNaN(element) &&
+ Number.isFinite(element)
+ );
 });


Some of the checks are redundant. Could you use AI to research how you could simplify the code on line 2-8?

yes, i have done some research and see that Number.isfinite sufficess

cjyuan · 2026-08-21T15:41:23Z

+ let sum = 0;
+ for (let i = 0; i < elementsList.length; i++) {
+ sum += elementsList[i];
+ }
+ return sum;


You also don't have to check if the array length is 1.

cjyuan · 2026-08-21T20:31:50Z

All good.

d-odumosu added 6 commits July 23, 2026 22:11

wrote the function to make the tests pas in median.js
3ac6be3

refactored this file from using array method .includes to using a for…
5fdea58
… of loop. all tests pass.

completed jest tests
7bde1b5

Implemented the find maximum function and all tests pass.
64b9210

Implemented the sum function and all tests pass.
f1f59ac

Implemented the dedupe function and all tests pass.
b881892

d-odumosu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module Module-Data-Groups The name of the module. labels Jul 26, 2026

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 31, 2026

cjyuan reviewed Jul 31, 2026
View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 31, 2026

made changes per review
f7ac75c

d-odumosu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 21, 2026

cjyuan reviewed Aug 21, 2026
View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 21, 2026

d-odumosu added 3 commits August 21, 2026 19:24

removed the redundant check in sum.js
99aab16

further simplified sum.js
5253409

fixed the test in dedupe
cba6d18

d-odumosu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 21, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 21, 2026

Uh oh!

Uh oh!

Conversation

d-odumosu commented Jul 26, 2026

Changelist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants