Skip to content

London | 26-ITP-May | Ebrahim Moqbel | Sprint 1 | course work - #1393

Open
Ebrahim-Moqbel wants to merge 5 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework-sprint-1
Open

London | 26-ITP-May | Ebrahim Moqbel | Sprint 1 | course work#1393
Ebrahim-Moqbel wants to merge 5 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:coursework-sprint-1

Conversation

@Ebrahim-Moqbel

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

refactored the code for the files in sprint-1

Questions

N/A

@Ebrahim-MoqbelEbrahim-Moqbel added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Aug 6, 2026

@LonMcGregorLonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this task is complete

if (numbersOnly.length ===0 ){
return -Infinity
}
const sorted = [...numbersOnly].sort((a,b) => a-b)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to use sorting

@LonMcGregorLonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Ebrahim-MoqbelEbrahim-Moqbel changed the title London | 26-ITP-May | Ebrahim Moqbel | Sprint -1 | course workLondon | 26-ITP-May | Ebrahim Moqbel | Sprint1 | course workAug 10, 2026
@github-actions

This comment has been minimized.

@Ebrahim-MoqbelEbrahim-Moqbel changed the title London | 26-ITP-May | Ebrahim Moqbel | Sprint1 | course workLondon | 26-ITP-May | Ebrahim Moqbel | Sprint 1 | course workAug 11, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-Data-GroupsThe name of the module.📅 Sprint 1Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Ebrahim-Moqbel@LonMcGregor