Skip to content

London | 26-ITP-May | Edina Kurdi | Sprint 3 | Todo List - #1429

Open
edinakurdi wants to merge 8 commits into
CodeYourFuture:mainfrom
edinakurdi:coursework/sprint-3-todo
Open

London | 26-ITP-May | Edina Kurdi | Sprint 3 | Todo List#1429
edinakurdi wants to merge 8 commits into
CodeYourFuture:mainfrom
edinakurdi:coursework/sprint-3-todo

Conversation

@edinakurdi

@edinakurdiedinakurdi commented Aug 13, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • added button to index.html
  • implemented deleteCompleted() in todos.mjs
  • wrote Jest test in todos.test.mjs
  • added event listener in script.mjs

@github-actions

This comment has been minimized.

Sign in to view
@edinakurdiedinakurdi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2026
@cjyuancjyuan changed the title London | 26-ITP-May | Edina Kurdi | Sprint 3 | To do ListLondon | 26-ITP-May | Edina Kurdi | Sprint 3 | Todo ListAug 13, 2026
@cjyuancjyuan added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2026
@edinakurdiedinakurdi added 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module Module-Data-Groups The name of the module. labels Aug 13, 2026
@hackertainmenthackertainment added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 20, 2026
@hackertainmenthackertainment mentioned this pull request Aug 20, 2026
Open
@hackertainment

hackertainment commented Aug 20, 2026

Copy link
Copy Markdown

Good try, and keep it up :-)

@hackertainmenthackertainment added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 20, 2026
@edinakurdi

edinakurdi commented Aug 20, 2026

Copy link
Copy Markdown
Author

Good try, and keep it up :-)

Thank you. Can you please provide some comments as to what to improve on?

@hackertainment

hackertainment commented Aug 21, 2026•
edited
Loading

Copy link
Copy Markdown
image

Oh, I commented directly with the corresponding lines of code. Two fixes required as shown in above. Thank you.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Module-Data-GroupsThe name of the module.🏕 Priority MandatoryThis work is expectedReviewedVolunteer to add when completing a review with trainee action still to take.📅 Sprint 3Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edinakurdi@hackertainment@cjyuan