Skip to content

London | May-2026-itp | Vitalii Kmit | Sprint 2 | Data Groups exercises - #1434

Open
Vitalii-code wants to merge 8 commits into
CodeYourFuture:mainfrom
Vitalii-code:sprint-2
Open

London | May-2026-itp | Vitalii Kmit | Sprint 2 | Data Groups exercises#1434
Vitalii-code wants to merge 8 commits into
CodeYourFuture:mainfrom
Vitalii-code:sprint-2

Conversation

@Vitalii-code

@Vitalii-codeVitalii-code commented Aug 14, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I worked on the Sprint 2 exercises

@Vitalii-codeVitalii-code added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2026
@Vitalii-codeVitalii-code mentioned this pull request Aug 14, 2026
Open
cjyuan
cjyuan reviewed Aug 14, 2026
View reviewed changes
Comment threadSprint-2/debug/author.js Outdated
for (const value of author) {
console.log(value);
}
console.log(author);

@cjyuancjyuanAug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This outputs a string representation of the object, which typically includes both the keys and values.

Could you modify it to output only the values in the object?

@Vitalii-codeVitalii-codeAug 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Comment threadSprint-2/implement/contains.js Outdated
Comment threadSprint-2/implement/lookup.js Outdated
Comment threadSprint-2/implement/querystring.js Outdated
@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 14, 2026
@Vitalii-codeVitalii-code added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 15, 2026
cjyuan
cjyuan reviewed Aug 15, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Could you also address this comment: #1434 (comment)

@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 15, 2026
@Vitalii-codeVitalii-code added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 15, 2026
cjyuan
cjyuan reviewed Aug 15, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@cjyuancjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 15, 2026
@Vitalii-code

Vitalii-code commented Aug 15, 2026

Copy link
Copy Markdown
Author

All good.

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuancjyuancjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vitalii-code@cjyuan