Skip to content

London | 26-ITP-May | Ebrahim Moqbel | sprint 3 | quote-generator#1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ebrahim-Moqbel wants to merge 4 commits into
base:main
Choose a base branch
from
Open

London | 26-ITP-May | Ebrahim Moqbel | sprint 3 | quote-generator #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93e950c
added the title name
Ebrahim-Moqbel Aug 21, 2026
e6fefea
implemented the function that display quotes
Ebrahim-Moqbel Aug 21, 2026
d32519b
added some style to the body and linked it to the index.html
Ebrahim-Moqbel Aug 21, 2026
192bcce
made some css style and made the page to display a quote when opening…
Ebrahim-Moqbel Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<link rel="stylesheet" href="style.css" />
<script defer src="quotes.js"></script>
</head>
<body>
Expand Down
17 changes: 17 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop

@cjyuancjyuanAug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the app to display a quote when the page is first loaded?

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
// Goal: page shows a random quote from the quotes array with displaying the author
// requirements:
// when clicking a button on the screen it changes the quote
const author = document.getElementById("author");
const quote = document.getElementById("quote");
const newQuoteButton = document.getElementById("new-quote");

newQuoteButton.addEventListener("click", () => {
displayQuote();
});

function displayQuote() {
const randomQuote = pickFromArray(quotes);
quote.textContent = randomQuote.quote;
author.textContent = randomQuote.author;
}
window.onload = displayQuote;

@cjyuancjyuanAug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better practice is to keep all the code that run once when the app starts in a function.

// DO NOT EDIT BELOW HERE

// pickFromArray is a function which will return one item, at
Expand Down
44 changes: 44 additions & 0 deletions Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1 +1,45 @@
/** Write your CSS in here **/
body{
font-family: Arial,sans-serif;
min-height: 100vh;
margin:0;
display: flex;
padding: 0 1rem;
background-color: #e2c8c8
}

* {
box-sizing: border-box;
}
main.quote-box {
max-width : 600px;
padding :2rem;
text-align : center;
}

#quote {
font-size : 1.5rem;
font-style : italic;
line-height: 1.4;
margin-bottom : 1rem;
}
#author {
font-size: 1rem;
font-weight: 600;
color: #272ad3;
margin-bottom : 2rem;
}
#new-quote {
padding: 0.6rem 1.4rem;
font-size: 1rem;
border: none;
border-radius: 6px;
background-color: #2b2b2b;
color: #fff;
cursor: pointer;
transition: background-color 0.15s ease;
}

#new-quote:hover {
background-color: #444;
}
Loading