Skip to content

London | 26-ITP-May | Zadri Abdule | Sprint 2 | Wireframe - #1168

Closed
Zadri415 wants to merge 35 commits into
CodeYourFuture:mainfrom
Zadri415:feature/wireframe
Closed

London | 26-ITP-May | Zadri Abdule | Sprint 2 | Wireframe#1168
Zadri415 wants to merge 35 commits into
CodeYourFuture:mainfrom
Zadri415:feature/wireframe

Conversation

@Zadri415

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Added three articles
Added a responsive layout, header, footer, improved accessibility

Zadri415 added 27 commits May 22, 2025 14:37
Fix links inconsistencies and remove ellipsis in HTML.
@netlify

netlifyBot commented Feb 10, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit9d357cd
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/698e37ad613ce400081cad91
😎 Deploy Previewhttps://deploy-preview-1168--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Zadri415Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 10, 2026
@Zadri415Zadri415 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Feb 10, 2026
@jenny-alexanderjenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 11, 2026

@jenny-alexanderjenny-alexander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zadri415 - you're wireframe exercise is done quite well. Nice work.

One item for you to review is the style of the the 'Read More' button. If you look at the wireframe exercise, you'll see that the button does not span the entire width of the container. Your button currently does. Can you make the adjustment?

Comment threadWireframe/index.html Outdated
</article>

<article>
<img src="https://i0.wp.com/digitalvarys.com/wp-content/uploads/2019/06/image-6.png?fit=640%2C257&ssl=1" alt="" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This <img> tag is missing something important for screen readers. Can you find the empty attribute?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jenny - Thanks for pointing that out. I've added a description to the empty alt attribute.

@jenny-alexanderjenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 11, 2026
@Zadri415Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 11, 2026
@jenny-alexander

Copy link
Copy Markdown
Contributor

@Zadri415 Thanks for updating the alt text.

There are a few style issues to be corrected in order for your webpage to resemble the wireframe.
Screenshot 2026-02-11 at 8 28 58 PM

@jenny-alexanderjenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026
@Zadri415Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026

@jenny-alexanderjenny-alexander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zadri415 I don't think you addressed the straight line underneath the header yet.

Comment threadWireframe/style.css Outdated
@jenny-alexanderjenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026
@Zadri415Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 12, 2026
@jenny-alexanderjenny-alexander added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 13, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

@Zadri415Zadri415 changed the title London | 26-ITP-Jan | Zadri Abdule | Sprint 1 | WireframeLondon | 26-ITP-May | Zadri Abdule | Sprint 1 | WireframeMay 5, 2026
@Zadri415Zadri415 changed the title London | 26-ITP-May | Zadri Abdule | Sprint 1 | WireframeLondon | 26-ITP-Jan | Zadri Abdule | Sprint 1 | WireframeMay 5, 2026
@Zadri415Zadri415 changed the title London | 26-ITP-Jan | Zadri Abdule | Sprint 1 | WireframeLondon | 26-ITP-May | Zadri Abdule | Sprint 2 | WireframeMay 17, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Zadri415@cjyuan@jenny-alexander@illicitonion