Uh oh!
There was an error while loading. Please reload this page.
Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 1 | Form Controls - #1237
Closed
Lavanya-Projects wants to merge 9 commits into
Closed
Glasgow | 26-ITP-May | Lavanya Jayaprabu | Sprint 1 | Form Controls#1237Lavanya-Projects wants to merge 9 commits into
Lavanya-Projects wants to merge 9 commits into
Conversation
Added a customer name input field
Added customer email input field
Added radio button for the colour selection
Added a dropdown section for the size selection
Added submit button, validate the input fields
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Comment on lines
+17
to
+18
| <label>Customer Name: </label> | ||
| <input required minlength="2" pattern=".*\S.*\S.*"> |
Contributor
There was a problem hiding this comment.
Recommended to have id and name fields here (name field helps data be identified, id helps elements get identified for CSS) -> this is the same for the email input
There was a problem hiding this comment.
Hi Poonam, Thank you for reviewing my code. I did some changes based on the feedback... Looking forward to receive the reply
Poonam-raj
left a comment
Contributor
There was a problem hiding this comment.
Good work - just add the name and id fields into the form. I would also format the code so the indenting is correct as currently the code is indented a bit randomly.
Do it manually, or you can use a code formatter like Prettier to format code for you if need be
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+28
to
+43
| <p>Choose a T‑shirt colour:</p> | ||
| <label> | ||
| <input type="radio" name="colour" value="red" required> | ||
| Red | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="colour" value="blue"> | ||
| Blue | ||
| </label> | ||
| <label> | ||
| <input type="radio" name="colour" value="black"> | ||
| Black | ||
| </label> |
Contributor
There was a problem hiding this comment.
I would consider wrapping this in a <fieldset> tag to group the related inputs which are to do with colours
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Poonam-raj
left a comment
Contributor
There was a problem hiding this comment.
Last few bits to fix - sorry for the delay getting feedback back to you
Poonam-raj
left a comment
Contributor
There was a problem hiding this comment.
Great work thanks for all the changes 🎉
illicitonion
commented
Aug 24, 2026
Member
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed all input fields based on the requirements. Validated all the code via validator.w3.org