Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 2 | Wireframe by Monsur0001 · Pull Request #1241 · CodeYourFuture/Module-JavaScript-Fundamentals

Monsur0001 · 2026-05-09T13:41:28Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Wireframe tasks completed.

netlify · 2026-05-09T13:41:33Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`44e6c0e`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1af8906eaf9f0008ade0ad
😎 Deploy Preview	https://deploy-preview-1241--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 96 (🔴 down 4 from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sambuxc

So far so good but a few things need addressing. Please take a look at my comments

Sambuxc · 2026-05-12T16:23:00Z

+ <p class="center">Practicing commits in Git</p>
 </header>
- <main>
+ <div class="container">


Is there a semantic tag you could use instead here?

Thank you so much for your feedback. I have switched back to the "main" semantic tag.

Sambuxc · 2026-05-12T16:23:25Z

- </main>
+ </div>
+
+ <div class="article-row">


Is there a semantic tag you could use instead here?

Thank you so much for your feedback. I have also switched this back to the "main" semantic tag.

Sambuxc · 2026-05-12T16:24:05Z

-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
 <head>


Your page head should include a title and description

Thank you so much for your feedback. I have added the description as suggested.

Sambuxc · 2026-05-12T16:26:30Z

 margin: 0 auto calc(var(--space) * 4) auto;
 }
 footer {
- position: fixed;


Why did you decide to remove the fixed position?

Thank you so much for your feedback. I noticed that when I leave the fixed position, I realized that my footer aligns back to the left instead of staying at the center. However, after deep research about the issue, I found that adding a width of 100% would easily solve the problem. I have made the correction immediately.

It looks much better now, however the text becomes unreadable when scrolling at the background shows the page content through it.
Can you think of a way to make sure the text either; does not overlap the page content when scroll, or has an appropriate background color to make the footer text always readable?

I really do appreciate your feedback. I have fixed the readability issue by adding a white background to the footer. I also added a padding to it to solve the overlapping issue, so the users can actually see the last line of the content.. Thank you so much.

This is looking really great now :)

Sambuxc · 2026-05-12T16:27:52Z

-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
 <head>


How have you linked your html to the style.css file?

Thank you for your feedback. I have linked my css with this line of code ""

Monsur0001 · 2026-05-13T14:33:47Z

I really appreciate your feedback on my pull request. I have made all the suggested corrections and I am looking forward for your further feedback on it. Thank you so much.

Monsur0001

I have done all the suggested corrections. Thank you so much as I anticipate your further feedback

JaypeeLan · 2026-05-27T06:17:45Z

I can see this PR has both "need review" and "reviewed" labels. Do you still need it to be reviewed?

Monsur0001 · 2026-05-27T12:21:33Z

I can see this PR has both "need review" and "reviewed" labels. Do you still need it to be reviewed?

Yes please. I have made the corrections pointed out by the former reviewer. That’s the reason I added the needs review label. Thank you so much

Sambuxc

This is looking great now, well done :)

illicitonion · 2026-08-24T09:41:15Z

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Monsur0001 added 5 commits April 11, 2026 15:38

What is a REAADME File?
f21d9eb

Purpose of a Wireframe
4735988

What is branch in Git?
2c16dc3

Features/Wireframe updated
e5260c4

What is branch in Git updated
aaa453c

This comment has been minimized.
Sign in to view

Monsur0001 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 9, 2026

This comment has been minimized.
Sign in to view

github-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 9, 2026

This comment has been minimized.
Sign in to view

Monsur0001 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. NotCoursework labels May 9, 2026

illicitonion removed the NotCoursework label May 9, 2026

Sambuxc added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 12, 2026

Sambuxc suggested changes May 12, 2026
View reviewed changes

What is branch in Git? updated
d79befd

Monsur0001 requested a review from Sambuxc May 13, 2026 14:34

Monsur0001 commented May 13, 2026
View reviewed changes

Readability issue solved
b60141e

Monsur0001 added 📅 Sprint 2 Assigned during Sprint 2 of this module and removed 📅 Sprint 1 Assigned during Sprint 1 of this module labels May 14, 2026

Monsur0001 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 15, 2026

Sambuxc approved these changes May 27, 2026
View reviewed changes

Monsur0001 mentioned this pull request May 30, 2026
26-ITP-May | Onboarding | Monsur Abdulrahman Monsur0001/My-Coursework-Planner#4
Open

Refactor HTML structure and update CSS margin for improved layout
44e6c0e

illicitonion closed this Aug 24, 2026

Uh oh!

Uh oh!

Conversation

Monsur0001 commented May 9, 2026

Changelist

Uh oh!

netlifyBot commented May 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Sambuxc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Monsur0001 commented May 13, 2026

Uh oh!

Monsur0001 left a comment

Choose a reason for hiding this comment

Uh oh!

JaypeeLan commented May 27, 2026

Uh oh!

Monsur0001 commented May 27, 2026

Uh oh!

Sambuxc left a comment

Choose a reason for hiding this comment

Uh oh!

illicitonion commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlifyBot commented May 9, 2026•
edited
Loading

Sambuxc left a comment •
edited
Loading