Skip to content

London | 26-ITP-May | Anita Amirhaeri | Sprint 1 | Form Controls#1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anitahy73 wants to merge 3 commits into from
Closed

London | 26-ITP-May | Anita Amirhaeri | Sprint 1 | Form Controls #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4311b4
Add form with input fields and options
anitahy73 May 9, 2026
c141d2a
Review issues fixed
anitahy73 May 15, 2026
1c14e49
Review issues fixed
anitahy73 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 40 additions & 8 deletions Form-Controls/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,48 @@
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
<form>

@Luro91Luro91May 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of the child is not correct. How could you ensure consistent formatting of the code?


<label for="name">Name:</label>
<input type="text" id="name" name="name"><br>

@Luro91Luro91May 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could you ensure that the name is at least 2 characters long?

<label for="email">Email:</label>
<input type="email" id="email" name="email"><br><br>

<fieldset>
<legend>colour:</legend>

<label>
<input type="radio" id="colour-red" name="colour" value="red">
Red
</label>

<label >
<input type="radio" id="colour-blue" name="colour" value="blue">
Blue
</label>

<label >
<input type="radio" id="colour-green" name="colour" value="green">
Green
</label>

</fieldset>

<label for="size">choose your size</label>


<select id="size">
<option value="s">small</option>
<option value="m">medium</option>
Comment on lines +26 to +47

@Luro91Luro91May 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could you ensure that the user needs to choose a color and size?

<option value="l">large</option>
<option value="xl">xlarge</option>
<option value="xl">xxlarge</option>

</select>
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>Anita Amirhaeri</p>
</footer>
</body>
</html>
87 changes: 50 additions & 37 deletions index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,46 +1,59 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Coursework</title>
<style>
:root {
--paper: oklch(7 0 0);
--ink: color-mix(in oklab, var(--color) 5%, black);
--font: 100%/1.5 system-ui;
--space: clamp(6px, 6px + 2vw, 15px);
--line: 1px solid;
}
body {
background: var(--paper);
color: var(--ink);
font: var(--font);
max-width: 1280px;
margin: 0 auto;
}
</style>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header><h1>🧐 CYF Coursework Disposable Branch Previews</h1></header>
<header>
<h1>Product Pick</h1>
</header>
<main>
<ol>
<li>
<h2><a href="/Wireframe">Project 1: Wireframe</a></h2>
<p>
Mentors:
<a href="Wireframe/readme.md">open the assignment in a tab</a>
</p>
</li>
<li>
<h2><a href="/Form-Controls">Project 2: Form Controls</a></h2>
<p>
Mentors:
<a href="Form-Controls/readme.md">open the assignment in a tab</a>
</p>
</li>
</ol>
<form>

<label for="name">Name:</label>
<input type="text" id="name" name="name"><br>
<label for="email">Email:</label>
<input type="email" id="email" name="email"><br><br>

<fieldset>
<legend>colour:</legend>

<label>
<input type="radio" id="colour-red" name="colour" value="red">
Red
</label>

<label >
<input type="radio" id="colour-blue" name="colour" value="blue">
Blue
</label>

<label >
<input type="radio" id="colour-green" name="colour" value="green">
Green
</label>

</fieldset>

<label for="size">choose your size</label>


<select id="size">
<option value="s">small</option>
<option value="m">medium</option>
<option value="l">large</option>
<option value="xl">xlarge</option>
<option value="xl">xxlarge</option>

</select>
</form>
</main>
<footer><a href="HOW_TO_REVIEW.md">HOW TO REVIEW MD</a></footer>
<footer>
<p>Anita Amirhaeri</p>
</footer>
</body>
</html>
Loading