Skip to content

London | 26-ITP-May | Alex Jamshidi | Sprint 2 | Wireframe - #1249

Closed
Alex-Jamshidi wants to merge 12 commits into
CodeYourFuture:mainfrom
Alex-Jamshidi:feature/wireframe
Closed

London | 26-ITP-May | Alex Jamshidi | Sprint 2 | Wireframe#1249
Alex-Jamshidi wants to merge 12 commits into
CodeYourFuture:mainfrom
Alex-Jamshidi:feature/wireframe

Conversation

@Alex-Jamshidi

@Alex-JamshidiAlex-Jamshidi commented May 10, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Updated website using html/css to ressemble wireframe.

@netlify

netlifyBot commented May 10, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit86e266c
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a072702c097c1000881d4ae
😎 Deploy Previewhttps://deploy-preview-1249--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Alex-JamshidiAlex-Jamshidi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 10, 2026
This was referenced May 10, 2026
Open
Open
illicitonion
illicitonion reviewed May 14, 2026
View reviewed changes
Comment threadWireframe/index.html
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<img src="img1.jpg" alt="" />

@illicitonionillicitonionMay 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you intentionally leaving these alt attributes empty? Sometimes it is correct to - if you are, why is it correct to here?

@Alex-JamshidiAlex-JamshidiMay 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could leave them empty if I were to feed through the alt text via code, however that is not the case here.

I have added suitable alt text.

@illicitonionillicitonionMay 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a read of https://www.boia.org/blog/when-should-i-use-empty-or-null-alt-text-attributes and see what you think :)

@Alex-JamshidiAlex-JamshidiMay 15, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay that makes sense.

An alt description isn't required for a decorative image, and best way to not pollute a screenreader with uneccessary text is to keep it empty.

updated code to reflect this. thanks

@illicitonionillicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 14, 2026
@Alex-JamshidiAlex-Jamshidi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 14, 2026
@illicitonionillicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 15, 2026
@Alex-JamshidiAlex-Jamshidi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 15, 2026
@illicitonionillicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 15, 2026
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonionillicitonionillicitonion left review comments

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alex-Jamshidi@illicitonion