Skip to content

London | 26-ITP-May | Remi M. B. | Sprint 1 | Form Controls - #1258

Closed
remimarcelle wants to merge 10 commits into
CodeYourFuture:mainfrom
remimarcelle:feature/form-controls
Closed

London | 26-ITP-May | Remi M. B. | Sprint 1 | Form Controls#1258
remimarcelle wants to merge 10 commits into
CodeYourFuture:mainfrom
remimarcelle:feature/form-controls

Conversation

@remimarcelle

@remimarcelleremimarcelle commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide
  • I have only used HTML, no CSS or JavaScript
  • My form is semantic HTML
  • All inputs have associated labels
  • My Lighthouse Accessibility score is 100
  • I require a valid name (minimum 2 characters)
  • I require a valid email
  • I require one colour from a defined set of 3 colours
  • I require one size from a defined set of 6 sizes
  • My code is consistently formatted
  • My page content is free of typos
  • I commit often and push regularly to GitHub
  • My HTML code has no errors or warnings (https://validator.w3.org/)

Changelist

Built a form to collect t-shirt orders using HTML only. It asks for the
customer's full name, email address, t-shirt colour (radio buttons) and
size (dropdown). Wrapped inputs and radio button labels in p tags to add
spacing between touch targets, bringing the Lighthouse accessibility
score from 92 to 100.

Questions

Do I have to screenshot that I used devtools to refactor before I changed the code in vscode?

@netlify

netlifyBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit37cfdea
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a065d250271d30008f31c51
😎 Deploy Previewhttps://deploy-preview-1258--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@remimarcelleremimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@remimarcelleremimarcelle changed the title London | 26-ITP-May | Remi M. B. | Onboarding-Sprint 1 | Form ControlsLondon | 26-ITP-May | Remi M. B. | Sprint 1 | Form ControlsMay 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@remimarcelleremimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@remimarcelleremimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@remimarcelle

remimarcelle commented May 12, 2026

Copy link
Copy Markdown
Author

It seems I accidently committed code from the wireframe task in this pull request? Idk how

@remimarcelleremimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@remimarcelle

remimarcelle commented May 12, 2026

Copy link
Copy Markdown
Author

remimarcelle/My-Coursework-Planner#16

@remimarcelleremimarcelle mentioned this pull request May 12, 2026
Closed
3 tasks
Luro91
Luro91 reviewed May 14, 2026
View reviewed changes

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a comment about the code formatting

Comment threadForm-Controls/index.html Outdated
Comment threadForm-Controls/index.html Outdated
@Luro91Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 14, 2026
@Luro91Luro91 added the Reviewed Volunteer to add when completing a review with trainee action still to take. label May 14, 2026
@remimarcelleremimarcelle mentioned this pull request May 14, 2026
Closed
@remimarcelleremimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 14, 2026
Luro91
Luro91 reviewed May 15, 2026
View reviewed changes

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.
Thanks for formatting the code. (FYI I also answered your comment here: https://github.com/CodeYourFuture/Module-Onboarding/pull/1258#discussion_r3246248845)

@Luro91Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 15, 2026
@remimarcelleremimarcelle changed the title London | 26-ITP-May | Remi M. B. | Sprint 1 | Form ControlsLondon | 26-ITP-May | Remi M. B. | Module-Onboarding Sprint 1 | Form ControlsMay 16, 2026
@github-actions

This comment has been minimized.

Sign in to view
@remimarcelleremimarcelle changed the title London | 26-ITP-May | Remi M. B. | Module-Onboarding Sprint 1 | Form ControlsLondon | 26-ITP-May | Remi M. B. | Sprint 1 | Form ControlsMay 16, 2026
@remimarcelleremimarcelle added the Module-Onboarding The name of the module. label May 22, 2026
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Luro91Luro91Luro91 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@remimarcelle@illicitonion@Luro91