Uh oh!
There was an error while loading. Please reload this page.
London | 26-ITP-May | Daniel Mears | Sprint 1 | Form Controls - #1261
London | 26-ITP-May | Daniel Mears | Sprint 1 | Form Controls#1261djmears-dev wants to merge 5 commits into
Conversation
djmears-dev
commented
May 13, 2026
- I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
- My changes meet the requirements of the task
- I have tested my changes
- My changes follow the style guide
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Luro91
left a comment
There was a problem hiding this comment.
When I run lighthouse in Google chrome I don't get a score of 100. How did you test this?
| <label for="name">Customer Name:</label> | ||
| <input |
There was a problem hiding this comment.
I find the code hard to read because of the formatting (indentation). How can you ensure consistent formatting in your code?
There was a problem hiding this comment.
Hi i've now formatted the code using prettier to make it more readable, i have also assured that the lighthouse accessibility is 100
| pattern=".*\S.{1,}.*" | ||
| > | ||
| <br><br> | ||
| <label for="email">Email Address:</label> | ||
| <input | ||
| type="email" | ||
| id="email" | ||
| name="email" | ||
| required |
There was a problem hiding this comment.
Good job on the validations and making things required
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works as expected and easy to read.
| <input type="radio" id="xs" name="size" value="XS" required /> | ||
| <label for="xs">XS</label> | ||
| <input type="radio" id="s" name="size" value="S" /> | ||
| <label for="s">S</label> | ||
| <input type="radio" id="m" name="size" value="M" /> | ||
| <label for="m">M</label> | ||
| <input type="radio" id="l" name="size" value="L" /> | ||
| <label for="l">L</label> | ||
| <input type="radio" id="xl" name="size" value="XL" /> | ||
| <label for="xl">XL</label> | ||
| <input type="radio" id="xxl" name="size" value="XXL" /> |
There was a problem hiding this comment.
FYI: I would switch around the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options a dropdown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)
illicitonion
commented
Aug 24, 2026
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |