Uh oh!
There was an error while loading. Please reload this page.
Glasgow | May 2026 | Craig Stoddart | Sprint 1 | Form Control - #1266
Glasgow | May 2026 | Craig Stoddart | Sprint 1 | Form Control#1266CraigStodd wants to merge 13 commits into
Conversation
…dded remaining sizes
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
One of the requirements has not yet been met: "All fields are required" -- it means the user should not be able to submit the form when any of the input field is missing a value.
Can you rename your branch to
feature/form-controls? (We missed specified the expected branch name in the backlog and I just updated it)- Suggestion: Ask AI what's the naming convention for branch name.
About the Changelist section of the PR description
- Some of the contents are not formatted properly
- Because the reviewers already know what the Form-Control exercise is, you can just state in this section that you have implemented an HTML form that meets all the requirements in the Form-Controls exercise. That is, you don't have to list the individual changes you made.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| <label>S: | ||
| <input type = "radio" id = "S" name = "Size" value = "S"> | ||
| </label> | ||
| <label>M: | ||
| <input type = "radio" id = "M" name = "Size" value = "M"> | ||
| </label> |
There was a problem hiding this comment.
Why introduce id attribute to each radio button input?
There was a problem hiding this comment.
Hi, I was following the tutorials linked in the curriculum which led me to believe this was necessary.

Learners, PR Template
Self checklist
Changelist
HTML
tags within each
CSS
,
elements
elements
elements
Questions