Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 1 | Form Controls by SandzSoft · Pull Request #1288 · CodeYourFuture/Module-JavaScript-Fundamentals

SandzSoft · 2026-05-16T11:33:55Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

A semantic HTML form
Required name and email validation
T-shirt colour selection
T-shirt size selection
CSS styling using Flexbox layout
Accessibility improvements

netlify · 2026-05-16T11:34:00Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`8a64dd7`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a19e4adbf43ff0008e6ed0f
😎 Deploy Preview	https://deploy-preview-1288--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Luro91

Looks quiet good. Everything is working as expected. I have some comments on the code formatting

Luro91 · 2026-05-20T04:30:28Z

Nice styling of the form. I like how it looks

Luro91 · 2026-05-20T04:32:16Z

+ <div class="container">
 <header>


The standard is to use intendation for children elements to make it easer to understand the html structure.How can you ensure consistent formatting in your code automatically?

I can ensure consistent formatting automatically by using a code formatter like Prettier in VS Code with “format on save” enabled, so indentation and structure are cleaned automatically every time I save the file.

Luro91 · 2026-05-20T04:32:27Z

- this will also help you fill in your PR message later-->
+ <div class="field"> 
+ <label for="customer_name">Name :</label>
+ <input minlength="2" required type="text" id="customer_name" name="customer_name">


Well done on the validation

Luro91 · 2026-05-20T04:32:46Z

+
+
+
+


These new lines are not needed.

Thank you for the feedback. I've removed the unnecessary blank lines.

Luro91

How can you ensure a lighthouse score of 100?

SandzSoft · 2026-05-27T08:36:24Z

How can you ensure a lighthouse score of 100?
Thank you for the feedback.
Use semantic HTML (header, main, footer)
Compress and optimize images
Keep CSS and JavaScript small
Add alt text to images
Use labels for form inputs
Make the site mobile-friendly
Fix accessibility and console errors
Use fast loading and responsive design
Avoid unnecessary animations

Luro91 · 2026-05-27T18:17:56Z

How can you ensure a lighthouse score of 100?
Thank you for the feedback.
Use semantic HTML (header, main, footer)
Compress and optimize images
Keep CSS and JavaScript small
Add alt text to images
Use labels for form inputs
Make the site mobile-friendly
Fix accessibility and console errors
Use fast loading and responsive design
Avoid unnecessary animations

In this case the SEO rating is at 90. Can you change the code to get it to 100?

SandzSoft · 2026-05-27T22:34:05Z

In this case the SEO rating is at 90. Can you change the code to get it to 100?

Thanks for the review. I didn’t notice the comment earlier because Lighthouse was showing 100% when I checked it before. However, I’ve now made several improvements to the page, including accessibility and responsive styling updates, to improve the overall Lighthouse scores.

Luro91

When I run lighthouse in Chrome it shows me a score of 90 for SEO. How can you improve this to 100?

SandzSoft · 2026-05-29T19:12:26Z

When I run lighthouse in Chrome it shows me a score of 90 for SEO. How can you improve this to 100?

Thanks for the review. When I initially ran Lighthouse, the SEO section was unticked, so I didn’t realise the score was lower because I was mainly checking the other categories. I’ve now updated the page by adding a meta description and making several accessibility and responsive styling improvements to improve the overall Lighthouse score.

Luro91

Well done the code works as expected and easy to read.

illicitonion · 2026-08-24T09:40:05Z

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

SandzSoft added 3 commits May 14, 2026 14:19

Create Product Pick form
ce896eb

Add CSS styling for Product Pick form
a4deffe

Refine form details and validation
f278f2c

This comment has been minimized.
Sign in to view

SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 16, 2026

Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 20, 2026

Luro91 reviewed May 20, 2026
View reviewed changes

Remove unwanted new lines
e26027f

SandzSoft mentioned this pull request May 24, 2026
26-ITP-May | Onboarding | Sandani Kannangara SandzSoft/My-Coursework-Planner#13
Open

SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 26, 2026

Luro91 reviewed May 27, 2026
View reviewed changes

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026

SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026

SandzSoft added 2 commits May 27, 2026 23:18

Improve form accessibility and responsive styling
a877cc3

Improve form accessibility in html
de00a67

SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026

Luro91 reviewed May 29, 2026
View reviewed changes

Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026

Add meta description for improved SEO
8a64dd7

SandzSoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 29, 2026

Luro91 reviewed May 30, 2026
View reviewed changes

SandzSoft mentioned this pull request Jun 6, 2026
Form Controls SandzSoft/My-Coursework-Planner#5
Open
3 tasks

illicitonion closed this Aug 24, 2026

Uh oh!

Uh oh!

Conversation

SandzSoft commented May 16, 2026

Learners, PR Template

Changelist

Uh oh!

netlifyBot commented May 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

Luro91May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Luro91May 20, 2026

Choose a reason for hiding this comment

Uh oh!

SandzSoftMay 21, 2026

Choose a reason for hiding this comment

Uh oh!

Luro91May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Luro91May 20, 2026

Choose a reason for hiding this comment

Uh oh!

SandzSoftMay 27, 2026

Choose a reason for hiding this comment

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

SandzSoft commented May 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Luro91 commented May 27, 2026

Uh oh!

SandzSoft commented May 27, 2026

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

SandzSoft commented May 29, 2026

Uh oh!

Luro91 left a comment

Choose a reason for hiding this comment

Uh oh!

illicitonion commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlifyBot commented May 16, 2026•
edited
Loading

SandzSoft commented May 27, 2026•
edited
Loading