London | ITP-May-2026 | Carolina Villa | Sprint 1 | Form Task by caro-vh · Pull Request #1295 · CodeYourFuture/Module-JavaScript-Fundamentals

caro-vh · 2026-05-16T13:34:04Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Used form controls to collect customers data, such as t-shirt colour and size.

netlify · 2026-05-16T13:34:08Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`02a20ab`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2addefabf1050008cc84c8
😎 Deploy Preview	https://deploy-preview-1295--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan

Code looks good.
Indentation is a bit inconsistent (both files). Can You follow this guide to enable "Format on Save" in VS Code or use VS Code's "Format Document" feature to keep your code consistently formatted?

cjyuan · 2026-05-17T01:57:38Z

+ name="full-name" 
+ required 
+ minlength="2" 
+ pattern=".*\S,*\S.*" 


Can you change this pattern so that it can also accept a name like "C J" (two characters separated by a space)?

Thanks for the review, I'll have a look and fix it.

cjyuan · 2026-05-17T02:00:22Z

+ <input type="radio" id="red" name="colour" value="red" required>
+ <label for="red">red</label> 


Note: If you wrap the <input> element inside <label>, you would not need to introduce id.

I see, I thought it was necessary for an easier manipulation in CSS, thank you for letting me know

cjyuan · 2026-05-17T02:12:11Z

Can you edit the PR description so that the "Changelist" word is a level-2 header instead of a normal paragraph?
That is, make it look like

Changelist

instead of

Changelist

…a space

cjyuan

Changes look good, but it seems you have accidently included the "GitHomeworkFixErrors" folder in your "Module-Onboarding" folder (on this branch). You need to remove that folder or move that folder out of your "Module-Onboarding" folder to keep this branch clean. Otherwise the Validation bot will reject your PR.

caro-vh · 2026-05-22T15:41:13Z

Thank you for letting me know, I'll fix it

cjyuan

All good. Well done.

cjyuan · 2026-05-22T17:32:00Z

+</body>
+
+</html>


It seems the code is manually indented.
You may want to follow this guide and
enable "Format on Save" in VS Code or use VS Code's "Format Document" feature to keep your code consistently formatted. It could save you some time.

Hello, thank you. I've done this now but I can't see any changes.

cjyuan · 2026-05-24T18:44:02Z

If the formatter does not work in VS Code, here are some possible causes:

The code has syntax error. According to validator.w3.org, there is an error in your HTML code.
- Normally when a HTML, CSS, or JS file has syntax error, VS Code would show its filename in red.
VSCode has more than one formatters that can be used to format the code and you have not yet selected the default formatter.

Can you try fixing the error and see if the formatter work after that?

caro-vh · 2026-06-03T17:38:09Z

Thank you for the advice. I have now fixed the problem and everithing seems to be working fine now.

cjyuan · 2026-06-03T19:34:53Z

Looks good.

cjyuan · 2026-06-11T14:47:55Z

Your PR has already completed.

Why add the _header file?

caro-vh · 2026-06-11T14:53:32Z

Hi, the reason for this is that I still had three neutral checks marked as incomplete. I thought I needed to take action to resolve them since the request wasn't showing as completed yet."

cjyuan · 2026-06-11T14:55:22Z

What neutral checks?

caro-vh · 2026-06-11T14:57:07Z

My apologies; I appear to have misread the information provided. I am correcting the issue immediately.

cjyuan · 2026-06-11T14:57:15Z

You still have not yet submitted your Wireframe PR. The deadline to complete Onboarding is 12 June (tomorrow). You need to hurry.

caro-vh · 2026-06-11T16:25:57Z

Hi, I've removed the file now. sorry I didn't read the information properly and got confused.

illicitonion · 2026-08-24T09:39:57Z

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

caro-vh added 8 commits May 14, 2026 18:33

Project Setup
9e12162

Name and email inputs
10dcfdb

Color Selection
922ea09

Colour and Size selection
04d8cc1

style: Increase margin between form groups
4a6cd68

fix: wrap each choice with a div command
5d1fad6

style: made space between colour choices wider for accesibility
46c4e88

fix: delate comments
8282146

caro-vh added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 16, 2026

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 17, 2026

cjyuan reviewed May 17, 2026
View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 17, 2026

caro-vh added 3 commits May 21, 2026 20:15

enable "Format on Save" in VS Code
9420646

change the pattern in name form to accept two caracters separated by …
fc8488d
…a space

fix: wrap <input> element inside <label> for a cleaner look
f15af4d

This comment has been minimized.
Sign in to view

caro-vh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 21, 2026

This comment has been minimized.
Sign in to view

github-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 21, 2026

cjyuan reviewed May 22, 2026
View reviewed changes

caro-vh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 22, 2026

This comment has been minimized.
Sign in to view

github-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 22, 2026

removed HomeworkFixErrors branch
0b752c0

cjyuan reviewed May 22, 2026
View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 22, 2026

enable automatic formating
3758890

caro-vh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 24, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 24, 2026

fix: intall formatter and test it
438c796

caro-vh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

process header rules
42cfc84

caro-vh added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026

Fix: remove _headers file
02a20ab

caro-vh mentioned this pull request Jun 12, 2026
ITP-May-2026 | Onboarding |Carolina Villa caro-vh/My-Coursework-Planner#28
Open

illicitonion closed this Aug 24, 2026

		<input type="radio" id="red" name="colour" value="red" required>
		<label for="red">red</label>

		</body>

		</html> No newline at end of file

Uh oh!

Uh oh!

Conversation

caro-vh commented May 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

netlifyBot commented May 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuanMay 17, 2026

Choose a reason for hiding this comment

Uh oh!

caro-vhMay 21, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuanMay 17, 2026

Choose a reason for hiding this comment

Uh oh!

caro-vhMay 21, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented May 17, 2026

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

caro-vh commented May 22, 2026

Uh oh!

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuanMay 22, 2026

Choose a reason for hiding this comment

Uh oh!

caro-vhMay 24, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented May 24, 2026

Uh oh!

caro-vh commented Jun 3, 2026

Uh oh!

cjyuan commented Jun 3, 2026

Uh oh!

cjyuan commented Jun 11, 2026

Uh oh!

caro-vh commented Jun 11, 2026

Uh oh!

cjyuan commented Jun 11, 2026

Uh oh!

caro-vh commented Jun 11, 2026

Uh oh!

cjyuan commented Jun 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

caro-vh commented Jun 11, 2026

Uh oh!

illicitonion commented Aug 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

caro-vh commented May 16, 2026•
edited
Loading

netlifyBot commented May 16, 2026•
edited
Loading

cjyuan commented Jun 11, 2026•
edited
Loading