Skip to content

WestMidlands | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Form Controls#1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KhotKeys wants to merge 3 commits into from
Closed

WestMidlands | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Form Controls #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6694a38
Complete forms assignment
KhotKeys May 18, 2026
87d2945
Complete forms assignment
KhotKeys May 18, 2026
bf756b0
Update index.html
KhotKeys May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 47 additions & 22 deletions Form-Controls/index.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,52 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>T-Shirt Order Form</title>
<link rel="stylesheet" href="style.css">
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
</footer>
</body>
<body>
<main class="container">
<h1>T-Shirt Order Form</h1>

<form>
<div>
<label for="name">Full Name</label>
<input type="text" id="name"name="name" minlength="2" pattern=".*\S.*\S.*" placeholder="Enter your full name" required>
Comment thread
Poonam-raj marked this conversation as resolved.

@Poonam-rajPoonam-rajJun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally you would leave feedback here that tells a user what the requirements are. Something to consider for future. Right now if I put less than two characters I get a message like this:

Image

But as a user, they won't necessarily know what the "format requested" is.

@KhotKeysKhotKeysJun 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great head-ups, worth notice for the future consideration, thanks

</div>

<div>
<label for="email">Email Address</label>
<input type="email" id="email" name="email" placeholder="Enter your email" required>

@jayshreehajgude2012jayshreehajgude2012May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct Input type and required is used .
can you tell how to validate email without using email type

@KhotKeysKhotKeysMay 21, 2026•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye‌s. Change type="email" t‍o type=‍"text" and‌ validate the in‍put yourself using JavaScript (for example, with a re‌gul‌ar expression)‍ or by using the pattern a‍ttribute. This le‍ts you enfor‍ce your own email validation rules instead of relying on the browser's built-in email valida‍tion.

@KhotKeysKhotKeysJun 9, 2026•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayshreehajgude2012, the review is ready.

@Poonam-rajPoonam-rajJun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct a pattern attribute is an alternative here :D

@KhotKeysKhotKeysJun 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right.

</div>

<div>
<label for="colour">T-Shirt Colour</label>
<select id="colour" name="colour" required>
<option value="">Select a colour</option>
<option value="black">Black</option>
<option value="white">White</option>
<option value="blue">Blue</option>
</select>
</div>

<div>
<label for="size">T-Shirt Size</label>
<select id="size" name="size" required>
<option value="">Select a size</option>
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>
Comment on lines +34 to +45

@Poonam-rajPoonam-rajJun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A semantic alternative to

tags in the form could be a tag

@KhotKeysKhotKeysJun 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to this. :)


<button type="submit">Place Order</button>
</form>
</main>

</body>
</html>
49 changes: 49 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
body {
font-family: Arial, sans-serif;
background-color: #f4f4f4;
margin: 0;
padding: 40px;
}
.container {
max-width: 500px;
margin: 0 auto;
background-color: #ffffff;
padding: 30px;
border-radius: 8px;
box-shadow: 0 2px 8px rgba(0, 0, 0, 0.1);
}
h1 {
text-align: center;
margin-bottom: 24px;
}
form {
display: flex;
flex-direction: column;
gap: 20px;
}
label {
display: block;
margin-bottom: 6px;
font-weight: bold;
}
input,
select {
width: 100%;
padding: 10px;
border: 1px solid #cccccc;
border-radius: 4px;
font-size: 16px;
box-sizing: border-box;
}
button {
padding: 12px;
border: none;
background-color: #000000;
color: white;
font-size: 16px;
border-radius: 4px;
cursor: pointer;
}
button:hover {
background-color: #2d758b;
}
Loading