Skip to content

London | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form Controls - #1316

Closed
cywong-dev wants to merge 11 commits into
CodeYourFuture:mainfrom
cywong-dev:staging-branch
Closed

London | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form Controls#1316
cywong-dev wants to merge 11 commits into
CodeYourFuture:mainfrom
cywong-dev:staging-branch

Conversation

@cywong-dev

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Display the form for the requirement with validation and display required

Questions

Nil

@netlify

netlifyBot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit253c27b
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2094bf02125b0008703f9d
😎 Deploy Previewhttps://deploy-preview-1316--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@cywong-devcywong-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@github-actions

This comment has been minimized.

@cywong-devcywong-dev changed the title London | ITP-May-2026 | Chun Yan Wong | Sprint1 | OnBoarding - Form-ControlsLondon | 26-ITP-May | Chun Yan Wong | Sprint 1 | Form ControlsMay 19, 2026
@cywong-devcywong-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 19, 2026
@cywong-devcywong-dev added the Module-Onboarding The name of the module. label May 19, 2026
@Luro91Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 20, 2026
Comment threadForm-Controls/index.html
Comment threadForm-Controls/index.html Outdated
Comment threadForm-Controls/index.html Outdated
Comment threadForm-Controls/index.html Outdated
Comment threadForm-Controls/index.html
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 20, 2026
@cywong-devcywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 20, 2026
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 21, 2026
@cywong-devcywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 24, 2026

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit

Comment threadForm-Controls/style.css Outdated
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 25, 2026
Original css script in the <script> tag was moved to the css file and the html file was changed to link the css script file by the tag <link>
@cywong-devcywong-dev added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 3, 2026
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 4, 2026

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done the code works as expected and easy to read.

@Luro91Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 4, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@cywong-dev@illicitonion@Luro91