Skip to content

Birmingham | may-2026-itp | Alexandra Clincu | Sprint 2 | Wireframe to Web Code - #1323

Closed
AlexandraClincu28 wants to merge 9 commits into
CodeYourFuture:mainfrom
AlexandraClincu28:feature/wireframe
Closed

Birmingham | may-2026-itp | Alexandra Clincu | Sprint 2 | Wireframe to Web Code#1323
AlexandraClincu28 wants to merge 9 commits into
CodeYourFuture:mainfrom
AlexandraClincu28:feature/wireframe

Conversation

@AlexandraClincu28

@AlexandraClincu28AlexandraClincu28 commented May 20, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

Created a Webpage based on the provided wireframe, styled the page using CSS and matched the layout to the wireframe design.

@netlify

netlifyBot commented May 20, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commitd966c20
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1f1ccef65fc40008f27ca7
😎 Deploy Previewhttps://deploy-preview-1323--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@AlexandraClincu28AlexandraClincu28 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 20, 2026
@LonMcGregorLonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 27, 2026
LonMcGregor
LonMcGregor reviewed May 27, 2026
View reviewed changes

@LonMcGregorLonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this task, there are a few changes you need to make

Comment threadWireframe/index.html Outdated
Comment threadWireframe/index.html
Comment threadWireframe/index.html Outdated
@LonMcGregorLonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026
@AlexandraClincu28AlexandraClincu28 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@LonMcGregorLonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@AlexandraClincu28AlexandraClincu28 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@LonMcGregor

LonMcGregor commented Jun 2, 2026

Copy link
Copy Markdown

Very close to being complete now! When I look on my screen, the footer is a bit too tall so it obscures part of the "read more" links in the bottom articles. Do you see that also on your device?

@LonMcGregorLonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@AlexandraClincu28
Update style.css
20eeacd
update footer
@AlexandraClincu28AlexandraClincu28 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@LonMcGregor

LonMcGregor commented Jun 2, 2026

Copy link
Copy Markdown

This is what I am seeing right now:
image

Do you also see the same thing?

@LonMcGregorLonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@AlexandraClincu28AlexandraClincu28 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@AlexandraClincu28

AlexandraClincu28 commented Jun 2, 2026

Copy link
Copy Markdown
Author

Thanks for the screenshot, that helped me understand the issue. I've made some adjustments to create more space below the content so the fixed footer shouldn't overlap the "Read more" links anymore. Thanks again for taking the time to review it.

@AlexandraClincu28AlexandraClincu28 mentioned this pull request Jun 2, 2026
Open
@LonMcGregor

LonMcGregor commented Jun 3, 2026

Copy link
Copy Markdown

Perfect! this task is now completed

@LonMcGregorLonMcGregor removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 3, 2026
@LonMcGregorLonMcGregor added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Jun 3, 2026
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregorLonMcGregorLonMcGregor left review comments

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexandraClincu28@LonMcGregor@illicitonion