Skip to content

West Midlands | 26-ITP-May | Alina Sofragiu | Sprint 2 | Wireframe - #1325

Closed
sofragiualina wants to merge 3 commits into
CodeYourFuture:mainfrom
sofragiualina:feature/wireframe
Closed

West Midlands | 26-ITP-May | Alina Sofragiu | Sprint 2 | Wireframe#1325
sofragiualina wants to merge 3 commits into
CodeYourFuture:mainfrom
sofragiualina:feature/wireframe

Conversation

@sofragiualina

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist

This PR adds the initial setup for the wireframe project following the Module-Onboarding instructions. It includes creating a dedicated feature branch and organising work in small, clear commits.

Updated content and structure of the wireframe HTML file.
Refactor CSS for layout and styling improvements.
@netlify

netlifyBot commented May 20, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit5e99e41
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a16c2c1471d9d00085d2a35
😎 Deploy Previewhttps://deploy-preview-1325--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sofragiualinasofragiualina added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels May 20, 2026
@LonMcGregorLonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 27, 2026

@LonMcGregorLonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this task is almost complete. See my comments for two very minor things to improve

Comment threadWireframe/index.html Outdated
alt="Git branches diagram" width="600" height="300" />
<h2>Git Branch</h2>
<p>LGit branches are separate versions of a project that allow developers to work on new features or fixes without changing the main code. In Git, changes can later be merged back into the main branch once they are ready.</p>
<a href="#">Read more</a>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change these links so they point to a real page? You can re-use an existing page on the internet

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add real external links and corrected spelling mistakes in the page content.

Comment threadWireframe/index.html Outdated
<img src="https://miro.medium.com/v2/1*K9scAx1Ezd-KJFabaYseCw.jpeg"
alt="Git branches diagram" width="600" height="300" />
<h2>Git Branch</h2>
<p>LGit branches are separate versions of a project that allow developers to work on new features or fixes without changing the main code. In Git, changes can later be merged back into the main branch once they are ready.</p>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGit - be careful of spelling errors.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I’ll pay more attention to small details

@LonMcGregorLonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
Corrected spelling errors and added real links.
@sofragiualinasofragiualina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026

@LonMcGregorLonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, this task is complete now

@LonMcGregorLonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 27, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sofragiualina@illicitonion@LonMcGregor