Uh oh!
There was an error while loading. Please reload this page.
Manchester | 26-ITP-May | Abdu Hassen | Sprint 1 | Form Controls - #1344
Manchester | 26-ITP-May | Abdu Hassen | Sprint 1 | Form Controls#1344Abduhasen wants to merge 3 commits into
Conversation
…elect for size choose,radio also for colour choose, used a lot <br> for spacing.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Luro91
left a comment
There was a problem hiding this comment.
How can you achieve a lighthouse score of 100?
| id="fname" | ||
| maxlength="10" | ||
| minlength="2" | ||
| pattern="[A-Za-z]+" |
There was a problem hiding this comment.
This does not allow special characters like the German ä,ü,ö
There was a problem hiding this comment.
the pattern boundaries was too strict i didn't observe it they way you did.
| id="fname" | ||
| maxlength="10" | ||
| minlength="2" | ||
| pattern="^[\p{L}][\p{L}\s'-]*$" |
There was a problem hiding this comment.
I see an javascript error on the console:Pattern attribute value ^[\p{L}][\p{L}\s'-]*$ is not a valid regular expression: Uncaught SyntaxError: Invalid regular expression: /^[\p{L}][\p{L}\s'-]*$/v: Invalid character in character class
There was a problem hiding this comment.
i used another Unicode character range, more specifically a Latin Extended character class to fix the pattern attribute.
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works as expected and easy to read.
illicitonion
commented
Aug 24, 2026
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
…elect for size choose,radio also for colour choose, used a lot
for spacing.
Learners, PR Template
Self checklist
Changelist
wrote a form control that takes first name, last name, email, colour and also size of a t-shirt i wrote form control using html
Questions
N/A