Skip to content

London | 26-ITP-May | Risikat Popoola | Sprint 1 | Form Controls - #1351

Closed
risikatpopoola wants to merge 8 commits into
CodeYourFuture:mainfrom
risikatpopoola:feature/form-controls
Closed

London | 26-ITP-May | Risikat Popoola | Sprint 1 | Form Controls#1351
risikatpopoola wants to merge 8 commits into
CodeYourFuture:mainfrom
risikatpopoola:feature/form-controls

Conversation

@risikatpopoola

@risikatpopoolarisikatpopoola commented May 25, 2026•
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR is for the form controls coursework

@netlify

netlifyBot commented May 25, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit93ae3c3
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1b6549edff760008e0e33a
😎 Deploy Previewhttps://deploy-preview-1351--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (🟢 up 3 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@risikatpopoolarisikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@risikatpopoolarisikatpopoola added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
@risikatpopoola
risikatpopoola marked this pull request as draft May 30, 2026 09:34
@risikatpopoola
risikatpopoola marked this pull request as ready for review May 30, 2026 09:35
@github-actions

This comment has been minimized.

Sign in to view
@risikatpopoolarisikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@risikatpopoolarisikatpopoola added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@cjyuancjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
cjyuan
cjyuan reviewed May 30, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, not all input elements are made required. I was able to submit the form without completing the form. Can you address this issue?

Comment threadForm-Controls/index.html Outdated
Comment threadForm-Controls/index.html
Comment threadForm-Controls/index.html Outdated
@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 30, 2026
@risikatpopoolarisikatpopoola added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 30, 2026
@cjyuan

cjyuan commented May 30, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback. (You can practice this in future PRs)
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuancjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
@risikatpopoolarisikatpopoola mentioned this pull request Jun 4, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuancjyuancjyuan left review comments

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.📅 Sprint 1Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@risikatpopoola@cjyuan@illicitonion