Uh oh!
There was an error while loading. Please reload this page.
London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Wireframe - #1363
Closed
tomdu3 wants to merge 19 commits into
Closed
London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Wireframe#1363tomdu3 wants to merge 19 commits into
tomdu3 wants to merge 19 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cjyuan
reviewed
May 30, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good and layout is pretty solid.
- To better match the wireframe, could you make the title and the "Read more" link of articles 2 and 3 fully aligned horizontally?
- Code is well formatted (manually? I assume). You may want to check out this guide to enable VS Code's "Format on Save" option or to use its "Format Document" command to keep your code always consistently formatted.
Contributor
There was a problem hiding this comment.
There are two main selectors in this file. Consider merging the properties from both selectors into a single main rule to make them easier to find and maintain.
Author
There was a problem hiding this comment.
I was using default HTML and CSS formatters. I have now formatted the files with Prettier.
Author
I have changed the alignment with picture ratio fix, integrated main in css. |
cjyuan
commented
May 30, 2026
Contributor
Changes look great. Well done! |
illicitonion
commented
Aug 24, 2026
Member
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Made HTML and CSS changes following the wireframe and instructions, containing the articles about wireframe, branch, and README