London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe

[shehu-dona]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Wireframe project completed. It has 2 articles with 3 different images and links.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	c6988db
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1df0cf4b4aa700070c3ed7
😎 Deploy Preview	https://deploy-preview-1371--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

• To better match the wireframe, can you
  • Keep the page title and text beneath it centered on the page
  • Make the title of articles 2 and 3 fully aligned horizontally
  • Prevent the footer and article content overlap

[cjyuan]

Changes look good.

• According to https://validator.w3.org/, there is an error in your code. Can you fix it?

• Note: If you have not yet enabled "Format on save" in VS Code, consider following this guide to enable VS Code's "Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.

---

Please also note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • You may find the suggestions in this PR Guide useful.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.

[shehu-dona]

Hello @cjyuan,

I removed the error in my code.
Also I enabled FormatOnSave.
For the future changes and PR I will follow the recommended steps.

[cjyuan]

Changes look good. Well done.

[illicitonion]

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.