Skip to content

London | 26-ITP-May | Eyob Zeray | Sprint 1 | Form controls - #1383

Closed
eyob-tech wants to merge 9 commits into
CodeYourFuture:mainfrom
eyob-tech:feature/form-controls
Closed

London | 26-ITP-May | Eyob Zeray | Sprint 1 | Form controls#1383
eyob-tech wants to merge 9 commits into
CodeYourFuture:mainfrom
eyob-tech:feature/form-controls

Conversation

@eyob-tech

@eyob-techeyob-tech commented May 31, 2026•
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I created a T-shirt order form by using HTML and CSS only.

@netlify

netlifyBot commented May 31, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commite579677
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a276d17c70f1e000805fbce
😎 Deploy Previewhttps://deploy-preview-1383--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 71 (🔴 down 15 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@eyob-techeyob-tech added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module Module-Onboarding The name of the module. labels May 31, 2026
@eyob-techeyob-tech added 🏕 Priority Mandatory This work is expected and removed 🏕 Priority Mandatory This work is expected labels Jun 1, 2026
@Luro91Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 3, 2026
Luro91
Luro91 reviewed Jun 3, 2026
View reviewed changes
Comment threadForm-Controls/index.html Outdated
Comment threadForm-Controls/index.html
Comment threadForm-Controls/index.html
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 3, 2026
@eyob-tech
Update index.html
d1ec3de
move CSS to separate file
@eyob-tech
Create style.css
a1143c1
paste CSS here
@eyob-tech
Update index.html
991b18a
@eyob-tech
Update index.html
20f153f
add form tag to enable validation
@eyob-techeyob-tech added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected and removed Reviewed Volunteer to add when completing a review with trainee action still to take. 🏕 Priority Mandatory This work is expected labels Jun 6, 2026
Luro91
Luro91 reviewed Jun 8, 2026
View reviewed changes
Comment threadForm-Controls/index.html
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 8, 2026
@eyob-techeyob-tech added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Module-Onboarding The name of the module. labels Jun 9, 2026
@eyob-techeyob-tech changed the title London | 25-ITP-May | Eyob Zeray | Sprint 1 | Form controlsLondon | 26-ITP-May | Eyob Zeray | Sprint 1 | Form controlsJun 9, 2026
@eyob-tech
eyob-tech requested a review from Luro91June 9, 2026 01:45
Luro91
Luro91 reviewed Jun 9, 2026
View reviewed changes

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done the code works as expected

@Luro91Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 9, 2026
@eyob-techeyob-tech mentioned this pull request Jun 9, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Luro91Luro91Luro91 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.📅 Sprint 1Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyob-tech@illicitonion@Luro91