Skip to content

London | 26-ITP-May | Gideon Defar | Sprint 1 | Form Control - #1388

Closed
gideondefar wants to merge 16 commits into
CodeYourFuture:mainfrom
gideondefar:feature/form-control
Closed

London | 26-ITP-May | Gideon Defar | Sprint 1 | Form Control#1388
gideondefar wants to merge 16 commits into
CodeYourFuture:mainfrom
gideondefar:feature/form-control

Conversation

@gideondefar

@gideondefargideondefar commented Jun 1, 2026

Copy link
Copy Markdown

Self checklist

  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist
Text input for name, and email input for email with proper validation. Select inputs for color and size with pre-defined choices. Validated with Lighthouse.

@netlify

netlifyBot commented Jun 1, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit60c2d63
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a20973837559b000856f26e
😎 Deploy Previewhttps://deploy-preview-1388--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 98 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@gideondefargideondefar added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 1, 2026
@gideondefar

gideondefar commented Jun 1, 2026

Copy link
Copy Markdown
Author

My pull request was labeled as completed, but there was a conflict of commits between my local and remote branches, where some commits were behind. I tried to sync fork, but it didn't work; then I merged the branch with the new PR.

@Luro91Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 3, 2026
Luro91
Luro91 reviewed Jun 3, 2026
View reviewed changes

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good. Only the minimum length needs to be fixed

Comment threadForm-Controls/index.html Outdated
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 3, 2026
@gideondefargideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module Complete Volunteer to add when work is complete and all review comments have been addressed. labels Jun 3, 2026
@gideondefargideondefar mentioned this pull request Jun 3, 2026
Open
@akeren
akeren self-requested a review June 3, 2026 17:16
@akerenakeren added 📅 Sprint 1 Assigned during Sprint 1 of this module Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Module-Onboarding The name of the module. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 3, 2026
akeren
akeren reviewed Jun 3, 2026
View reviewed changes

@akerenakeren left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gideondefar, any reason you didn't apply CSS to your semantic HTML form?

Comment threadForm-Controls/index.html Outdated
@akerenakeren added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 3, 2026
@gideondefargideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@gideondefargideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Module-Onboarding The name of the module. labels Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@gideondefargideondefar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@gideondefargideondefar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jun 3, 2026
@gideondefar

gideondefar commented Jun 3, 2026

Copy link
Copy Markdown
Author

@gideondefar, any reason you didn't apply CSS to your semantic HTML form?

It was by mistake, but now I've sorted it out; they are successfully linked.

@Luro91Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 4, 2026
Luro91
Luro91 reviewed Jun 4, 2026
View reviewed changes

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done the code works as expected and easy to read.

@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Luro91Luro91Luro91 left review comments
@akerenakerenakeren left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@gideondefargideondefar

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.📅 Sprint 1Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gideondefar@illicitonion@Luro91@akeren