Manchester |26-ITP-May| SamreenAmjad |Sprint 1 | Form-Controls by serveyano · Pull Request #1393 · CodeYourFuture/Module-JavaScript-Fundamentals

serveyano · 2026-06-01T20:52:22Z

Learners, PR Template

Self checklist

✓ I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
✓ My changes meet the requirements of the task
✓ I have tested my changes
✓ My changes follow the style guide

Changelist

This PR creates a T-shirt order form using semantic HTML. It collects the user’s name, email, colour, and size.

netlify · 2026-06-01T20:52:27Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`82e9a1d`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1df47ffe6f890008143915
😎 Deploy Preview	https://deploy-preview-1393--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-06-01T20:52:41Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T20:53:02Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T20:53:15Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T20:53:34Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T20:53:39Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-01T20:53:40Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-03T17:43:32Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-03T17:43:32Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

akeren

@serveyano, your codebase structure is currently simple and easy to follow, with index.html and style.css kept in the same root directory.

As your projects grow, what might happen if you later add more CSS files, JavaScript files, images, or multiple pages? How could you organise your folders so the project stays easy to navigate and maintain?

akeren · 2026-06-03T17:52:07Z

+ <input
+ type="email"
+ id="email"
+ name="email"
+ required
+ >


@serveyano, your email validation at the moment accepts invalid email addresses. For example, .@gmail.com, hi@example.com, and lots more can pass. How could you prevent this vulnerability?

akeren · 2026-06-03T17:59:49Z

+form {
+ background-color: white;
+ padding: 30px;
+ border-radius: 10px;
+ width: 350px;
+}
+
+h1 {
+ text-align: center;
+ margin-bottom: 20px;
+}
+
+.form-group {
+ margin-bottom: 15px;
+}
+
+label {
+ display: block;
+ margin-bottom: 5px;
+ font-weight: bold;
+}
+
+input,
+select {
+ width: 100%;
+ padding: 10px;
+}
+
+button {
+ width: 100%;
+ padding: 10px;
+ border: none;
+ background-color: black;
+ color: white;
+ cursor: pointer;
+}
+
+button:hover {
+ background-color: #333;
+}


@serveyano, your styling is visually strong. However, at the moment, many styles are applied directly to HTML tags. How might this affect other elements elsewhere on the page that use the same tags? What approach could give you more control over which specific elements receive these styles?

github-actions · 2026-06-03T18:05:13Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-06-03T18:05:13Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

akeren · 2026-06-03T18:09:34Z

@serveyano, why did you include the Wireframe directory as part of this pull request?

serveyano · 2026-06-06T14:37:11Z

I had an issue with branches, it accidentally committed it here

serveyano added 3 commits May 22, 2026 10:15

Added T-shirt order form project
6709ec3

improved
8f01d67

Complete T-shirt order form
d560024

serveyano added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026

github-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026

serveyano added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 1, 2026

github-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026

serveyano added 3 commits June 1, 2026 21:56

Fix HTML structure and separate CSS properly
d261537

Remove nested repo causing Netlify submodule error
c2fc5e4

Improve SEO and fix HTML structure
82e9a1d

akeren assigned serveyano Jun 3, 2026

akeren self-requested a review June 3, 2026 17:42

akeren added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Module-Onboarding The name of the module. labels Jun 3, 2026

akeren reviewed Jun 3, 2026
View reviewed changes

akeren added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 3, 2026

serveyano closed this Jun 8, 2026

serveyano deleted the feature/form-controls branch June 8, 2026 23:01

Uh oh!

Uh oh!

Conversation

serveyano commented Jun 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Uh oh!

netlifyBot commented Jun 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

github-actionsBot commented Jun 1, 2026

Uh oh!

github-actionsBot commented Jun 1, 2026

Uh oh!

github-actionsBot commented Jun 1, 2026

Uh oh!

github-actionsBot commented Jun 1, 2026

Uh oh!

github-actionsBot commented Jun 1, 2026

Uh oh!

github-actionsBot commented Jun 1, 2026

Uh oh!

github-actionsBot commented Jun 3, 2026

Uh oh!

github-actionsBot commented Jun 3, 2026

Uh oh!

akeren left a comment

Choose a reason for hiding this comment

Uh oh!

akerenJun 3, 2026

Choose a reason for hiding this comment

Uh oh!

akerenJun 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Jun 3, 2026

Uh oh!

github-actionsBot commented Jun 3, 2026

Uh oh!

akeren commented Jun 3, 2026

Uh oh!

serveyano commented Jun 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serveyano commented Jun 1, 2026•
edited
Loading

netlifyBot commented Jun 1, 2026•
edited
Loading