Skip to content

London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/Wireframe - #1397

Closed
vmoratti wants to merge 13 commits into
CodeYourFuture:mainfrom
vmoratti:feature/Wireframe
Closed

London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/Wireframe#1397
vmoratti wants to merge 13 commits into
CodeYourFuture:mainfrom
vmoratti:feature/Wireframe

Conversation

@vmoratti

@vmorattivmoratti commented Jun 1, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I had to delete all the previous branches and redo it from scratch.

@netlify

netlifyBot commented Jun 1, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit7139bda
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a23e65c6bc5080008e03af9
😎 Deploy Previewhttps://deploy-preview-1397--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 96 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@vmorattivmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmorattivmoratti changed the title London | 26-ITP-May | Vito Moratti | Sprint 1 | feature/WireframeLondon | 26-ITP-May | Vito Moratti | Sprint 1 | Feature/WireframeJun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmorattivmoratti changed the title London | 26-ITP-May | Vito Moratti | Sprint 1 | Feature/WireframeLondon | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/wireframeJun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmorattivmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 1, 2026
@vmorattivmoratti changed the title London | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/wireframeLondon | 26-ITP-May | Vito Moratti | Sprint 2 | Feature/WireframeJun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@vmorattivmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@vmorattivmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@vmorattivmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@akeren

akeren commented Jun 5, 2026

Copy link
Copy Markdown

@vmoratti, review the comments and resolve the issues highlighted...

@vmoratti

vmoratti commented Jun 5, 2026

Copy link
Copy Markdown
Author

I have tried to resolve it. Please advice.

akeren
akeren reviewed Jun 5, 2026
View reviewed changes
Comment threadWireframe/index.html
Comment on lines +12 to +22
<header>
<h1>Wireframe</h1>
<p>
This page will show:
</p>
<ul>
<li>Purpose of README file</li>
<li>Purpose of Wireframe</li>
<li>What is branch in Git</li>
</ul>
</header>

@akerenakerenJun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmoratti, compare the header with the main section of the page. Does the alignment look intentional? What CSS change might help align them?

@vmorattivmorattiJun 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made adjustments. The header section is centered now.

Comment threadWireframe/index.html Outdated
It allows you to diverge from the mainline of development and work on features, experiments, or bug fixes
without affecting the main codebase.
</p>
<a href="https://en.wikipedia.org/wiki/Git_branch">Read more</a>

@akerenakerenJun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmoratti, why is this UI experience not the same as the rest of the links?

@vmorattivmorattiJun 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the link to more information about git branch.

@akerenakerenJun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmoratti, I am referring to the appearance of the button. Compare it with the rest. Think of what has to change to make it appear the same as the rest.

@vmorattivmorattiJun 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added max-height to the anchor element in CSS file. "Read more" buttons appear the same size now.

@akeren

akeren commented Jun 5, 2026

Copy link
Copy Markdown

I have tried to resolve it. Please advice.

@vmoratti, please try and follow these instructions 👉 https://deploy-preview-1397--cyf-onboarding-module.netlify.app/Wireframe/readme.md

@akerenakeren added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@vmorattivmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@vmorattivmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@vmorattivmoratti added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected labels Jun 6, 2026
@akerenakeren added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 6, 2026
@vmorattivmoratti mentioned this pull request Jun 7, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@akerenakerenakeren left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@vmorattivmoratti

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoratti@akeren@illicitonion