Skip to content

London | 26-ITP-May | Talia Kucuk | Sprint 2 | Wireframe - #1399

Closed
TaliaKucuk wants to merge 12 commits into
CodeYourFuture:mainfrom
TaliaKucuk:feature/wireframe
Closed

London | 26-ITP-May | Talia Kucuk | Sprint 2 | Wireframe#1399
TaliaKucuk wants to merge 12 commits into
CodeYourFuture:mainfrom
TaliaKucuk:feature/wireframe

Conversation

@TaliaKucuk

@TaliaKucukTaliaKucuk commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This is my submission for the Sprint 2 Wireframe task.

@netlify

netlifyBot commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commitfc4d6c3
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a242ac9da76720008cfcbcb
😎 Deploy Previewhttps://deploy-preview-1399--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@TaliaKucukTaliaKucuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
@github-actions

This comment has been minimized.

Sign in to view
@TaliaKucukTaliaKucuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 2, 2026
cjyuan
cjyuan reviewed Jun 5, 2026
View reviewed changes

@cjyuancjyuan left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is well formatted and error-free, and page layout match the wireframe well. Good job!

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

    • After you have made the footer fixed, please also ensure the footer and the article text content won't overlap.

  • Your PR description is missing a "Changelist section". See this guide for more info.

@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026
@TaliaKucuk

TaliaKucuk commented Jun 6, 2026

Copy link
Copy Markdown
Author

Code is well formatted and error-free, and page layout match the wireframe well. Good job!

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

    • After you have made the footer fixed, please also ensure the footer and the article text content won't overlap.

  • Your PR description is missing a "Changelist section". See this guide for more info.

@TaliaKucukTaliaKucuk reopened this Jun 6, 2026
@TaliaKucuk

TaliaKucuk commented Jun 6, 2026

Copy link
Copy Markdown
Author

Hi I have now edited the code so that the footer is fixed and does not overlap with main content. I've also added the changelist to PR description.

@TaliaKucukTaliaKucuk added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@cjyuan

cjyuan commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done.

@cjyuancjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 6, 2026
@TaliaKucukTaliaKucuk mentioned this pull request Jun 9, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuancjyuancjyuan left review comments

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TaliaKucuk@cjyuan@illicitonion