Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 500
London | 26-ITP-May | Hugh Mills | Sprint 2 | Wireframe to web code#1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
e4d7a04c2fd516ede0704a9b67f1c2c02e074566dd6c3a2e608e533aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -24,23 +24,29 @@ As well as useful links to learn more */ | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| } | ||
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| } | ||
| a { | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| max-width: fit-content; | ||
| max-height: fit-content; | ||
| } | ||
| img, | ||
| svg { | ||
| width: 100%; | ||
| aspect-ratio:16/9 ; | ||
| object-fit: cover; | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| @@ -49,11 +55,37 @@ main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| header { | ||
| text-align:center; | ||
| max-width: fit-content; | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| } | ||
| h1 { | ||
| text-align:center; | ||
| font-size: 4em; | ||
| max-width: fit-content; | ||
| font-weight: bold; | ||
| font-family: 'Times New Roman', Times, serif; | ||
| } | ||
| #top-comment { | ||
| text-align:center; | ||
| margin-bottom: 20px; | ||
| } | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| text-align: center; | ||
| color: white; | ||
| padding-top: 10px; | ||
| background-color: rgb(28, 77, 127); | ||
| width:100% | ||
| } | ||
Comment on lines
+59
to
87
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HM-127BTY, how could you improve the readability and the separation between blocks of code? Author There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My best guess would be spacing, keeping a clear line between them would help to break it up and make it more readable? | ||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
| Inspect this in Devtools and click the "grid" button in the Elements view | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HM-127BTY, why is this anchor link UI different from the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure why it is doing that, could be because it is the last item in all the articles before footer? I will look into it tomorrow, hopefully with some assistance from others in the class on Saturday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worked it out, I did not have a height set for it, so added "max-height: fit-content;" this helped make them match.