Skip to content

London | 26-ITP-May | Damilola Odumosu | Sprint 2 | Wireframe - #1410

Closed
d-odumosu wants to merge 4 commits into
CodeYourFuture:mainfrom
d-odumosu:wireframe
Closed

London | 26-ITP-May | Damilola Odumosu | Sprint 2 | Wireframe#1410
d-odumosu wants to merge 4 commits into
CodeYourFuture:mainfrom
d-odumosu:wireframe

Conversation

@d-odumosu

Copy link
Copy Markdown

London | 26-ITP-May | Damilola Odumosu | Sprint 2 | Wireframe

Learners, PR Template

Self checklist

  • [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x] My changes follow the style guide

Changelist

Web page built using the provided wireframe .
I have had to delete and create a new branch has i was getting pr validation error.

@netlify

netlifyBot commented Jun 3, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit5f2dc8a
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2405d313ad370008ae017a
😎 Deploy Previewhttps://deploy-preview-1410--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 98 (🔴 down 2 from production)
Accessibility: 98 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@d-odumosud-odumosu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@akeren
akeren self-requested a review June 5, 2026 08:59
@akerenakeren added 📅 Sprint 2 Assigned during Sprint 2 of this module Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Module-Onboarding The name of the module. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026

@akerenakeren left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-odumosu, your codebase is well-structured, simple, and easy to follow.

  • As your projects grow, what might happen if you later add more CSS or JavaScript files?

  • How could you organise your folders so the project stays easy to navigate, scalable, and maintainable now and in the future?

@akerenakeren added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026
@d-odumosu

Copy link
Copy Markdown
Author

@d-odumosu, your codebase is well-structured, simple, and easy to follow.

  • As your projects grow, what might happen if you later add more CSS or JavaScript files?
  • How could you organise your folders so the project stays easy to navigate, scalable, and maintainable now and in the future?

Thank you akeren, i think that would be creating folders for CSS and Javascript, so when i have multiple files they can live in their own folders.

@d-odumosud-odumosu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 6, 2026
@akeren

Copy link
Copy Markdown

@d-odumosu, your codebase is well-structured, simple, and easy to follow.

  • As your projects grow, what might happen if you later add more CSS or JavaScript files?
  • How could you organise your folders so the project stays easy to navigate, scalable, and maintainable now and in the future?

Thank you akeren, i think that would be creating folders for CSS and Javascript, so when i have multiple files they can live in their own folders.

Nice work @d-odumosu!

@akerenakeren added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 6, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@d-odumosu@akeren@illicitonion