Skip to content

London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code - #1242

Open
Ebrahim-Moqbel wants to merge 29 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:feature/wireframe
Open

London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web code#1242
Ebrahim-Moqbel wants to merge 29 commits into
CodeYourFuture:mainfrom
Ebrahim-Moqbel:feature/wireframe

Conversation

@Ebrahim-Moqbel

@Ebrahim-MoqbelEbrahim-Moqbel commented May 9, 2026•
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have a added content and images with layout standing by CSS and HTML

@netlify

netlifyBot commented May 9, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit2c397b4
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a7318c17fd49000088180a9
😎 Deploy Previewhttps://deploy-preview-1242--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 91 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@RaihanSharif

RaihanSharif commented May 9, 2026

Copy link
Copy Markdown

Wireframe must be in sprint 2. They changed it from the Jan cohort.

@Poonam-raj

Poonam-raj commented May 22, 2026

Copy link
Copy Markdown
Contributor

@Ebrahim-Moqbel - I believe you still need to add a "Needs Review" label to this work for it to be reviewed by a volunteer and submitted

@Poonam-raj

Poonam-raj commented May 22, 2026

Copy link
Copy Markdown
Contributor

Wireframe must be in sprint 2. They changed it from the Jan cohort.

^^ Agreed with this, your PR title doesn't reflect the sprint that Wireframe to Web Code actually sits in now

@Ebrahim-Moqbel

Ebrahim-Moqbel commented Jun 5, 2026

Copy link
Copy Markdown
Author

Thank you I will update it accordingly

@Ebrahim-MoqbelEbrahim-Moqbel changed the title London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 2 | Wireframe to Web codeJun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ebrahim-MoqbelEbrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@Ebrahim-MoqbelEbrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@SambuxcSambuxc added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026
Sambuxc
Sambuxc reviewed Jun 5, 2026
View reviewed changes

@SambuxcSambuxc left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi please take a look at the questions I've raised in your file changes. Thanks :)

Comment threadWireframe/index.html Outdated
Comment threadWireframe/index.html Outdated
Comment threadWireframe/style.css Outdated
@SambuxcSambuxc added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026
Sambuxc
Sambuxc reviewed Jun 5, 2026
View reviewed changes
Comment threadWireframe/index.html
@Ebrahim-MoqbelEbrahim-Moqbel added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Aug 5, 2026
Sambuxc

This comment was marked as resolved.

Sign in to view

@SambuxcSambuxc added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 6, 2026
@Sambuxc

Sambuxc commented Aug 6, 2026

Copy link
Copy Markdown

Well done for resolving the final points.

This looks good now and has passed :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@SambuxcSambuxcSambuxc left review comments
Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-OnboardingThe name of the module.📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ebrahim-Moqbel@RaihanSharif@Poonam-raj@Sambuxc