Skip to content

Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control - #1257

Closed
TTiamiyu wants to merge 9 commits into
CodeYourFuture:mainfrom
TTiamiyu:Toluwalase-Form-Control
Closed

Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1257
TTiamiyu wants to merge 9 commits into
CodeYourFuture:mainfrom
TTiamiyu:Toluwalase-Form-Control

Conversation

@TTiamiyu

@TTiamiyuTTiamiyu commented May 12, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Enhances form accessibility and consistency by standardizing label capitalization and aligning input names and IDs. Updates option values for clarity and readability.

@netlify

netlifyBot commented May 12, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commitb7f62ac
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1c33b952bde9000896f722
😎 Deploy Previewhttps://deploy-preview-1257--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (🟢 up 4 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@TTiamiyuTTiamiyu changed the title Update index.html to enhance form accessibility and improve content c…Birmingham | ITP May | Toluwalase Tiamiyu | Sprint 1 | COURSEWORKMay 12, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@TTiamiyuTTiamiyu added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 12, 2026
@github-actions

This comment has been minimized.

@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@TTiamiyuTTiamiyu changed the title Birmingham | ITP May | Toluwalase Tiamiyu | Sprint 1 | COURSEWORKBirmingham | ITP May | Toluwalase Tiamiyu | Sprint 1 | Form-ControlMay 12, 2026
@TTiamiyuTTiamiyu changed the title Birmingham | ITP May | Toluwalase Tiamiyu | Sprint 1 | Form-ControlBirmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form ControlMay 12, 2026
@Poonam-raj

Copy link
Copy Markdown
Contributor

@TTiamiyu
Please add the "Needs Review" label to this Pull Request

@TTiamiyuTTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 22, 2026
@Luro91Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label May 23, 2026
Comment threadForm-Controls/index.html Outdated
@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 23, 2026
@Luro91

Copy link
Copy Markdown

I see erros in the w3 validator

@TTiamiyu
TTiamiyu requested a review from Luro91May 23, 2026 23:18
@TTiamiyuTTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 24, 2026

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit

Comment threadForm-Controls/index.html Outdated
@Luro91Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 25, 2026
i have rectified the errors regarding the white spaces in the "ID" and "Select name" attribute, i also used the validator.w3.org to check and it showed no errors
@TTiamiyuTTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 26, 2026
@Luro91Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
error seen by W3 validator regarding the "label for" not identical to the id, i have adjusted the case to align them.
@TTiamiyuTTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 31, 2026
@github-actions

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 31, 2026
removed the wireframe files from the form controls file, as it was committed here in error
…d added a button placement to make it look more like a form
@TTiamiyuTTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 31, 2026
@github-actions

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Form-Controls/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 31, 2026
@TTiamiyu

Copy link
Copy Markdown
Author

@Luro91, i closed this PR due to some errors in commits, i have created a new PR with this link

#1416

@TTiamiyuTTiamiyu closed this Jun 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-OnboardingThe name of the module.ReviewedVolunteer to add when completing a review with trainee action still to take.📅 Sprint 1Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TTiamiyu@Poonam-raj@Luro91