Skip to content

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe - #1422

Open
JohnRob-jnr wants to merge 6 commits into
CodeYourFuture:mainfrom
JohnRob-jnr:Wireframe2
Open

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe#1422
JohnRob-jnr wants to merge 6 commits into
CodeYourFuture:mainfrom
JohnRob-jnr:Wireframe2

Conversation

@JohnRob-jnr

@JohnRob-jnrJohnRob-jnr commented Jun 6, 2026•
edited
Loading

Copy link
Copy Markdown

Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Resubmitted my Wireframe as I made an error when working on it previously that would not allow it to be submitted for a pull request

Changelist

In this commit corrected the typo, added fixed footer and formatted CSS

@netlify

netlifyBot commented Jun 6, 2026•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

NameLink
🔨 Latest commit2fa740c
🔍 Latest deploy loghttps://app.netlify.com/projects/cyf-onboarding-module/deploys/6a273cc1e04aa60008ea8ba7
😎 Deploy Previewhttps://deploy-preview-1422--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@JohnRob-jnrJohnRob-jnr added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@JohnRob-jnrJohnRob-jnr added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Core This is a core task and should be completed by all trainees labels Jun 6, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@JohnRob-jnrJohnRob-jnr added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
cjyuan
cjyuan reviewed Jun 7, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error-free and page layout matches the wireframe well. Good job! It would probably match the wireframe better if all articles have the same padding space.

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  • I noticed some typo. Could you run the page content through an AI tool to identify any potential improvements, even minor ones, to help ensure the content is fully polished?

Comment threadWireframe/style.css Outdated
Comment threadWireframe/index.html Outdated
@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 7, 2026
@cjyuan

cjyuan commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Can you also restore the "Changelist" header in the PR description? It should be a level 2 header that looks like this:

Changelist

@JohnRob-jnrJohnRob-jnr added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 8, 2026
@cjyuan

cjyuan commented Jun 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes look good.

Can you also address this comment: #1422 (comment) (Look up "How to format a level-2 header in Markdown syntax")

I will mark this PR as "Complete" first.

@cjyuancjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 8, 2026
@JohnRob-jnrJohnRob-jnr mentioned this pull request Jun 10, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuancjyuancjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.CoreThis is a core task and should be completed by all trainees📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohnRob-jnr@cjyuan