Skip to content

Cape Town |ITP-MAY-26|Enice Mutanda|Sprint 2| Coursework - #1400

Open
Enice-Codes wants to merge 8 commits into
CodeYourFuture:mainfrom
Enice-Codes:coursework/sprint-2
Open

Cape Town |ITP-MAY-26|Enice Mutanda|Sprint 2| Coursework #1400
Enice-Codes wants to merge 8 commits into
CodeYourFuture:mainfrom
Enice-Codes:coursework/sprint-2

Conversation

@Enice-Codes

@Enice-CodesEnice-Codes commented Jun 25, 2026•
edited
Loading

Copy link
Copy Markdown

Self Check

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Answered questions to all excerises
completed code
checked code on node
Used Dev tools as per an excercise

@github-actions

This comment has been minimized.

Sign in to view
5 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Enice-CodesEnice-Codes added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 25, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Enice-CodesEnice-Codes added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 27, 2026
@Enice-CodesEnice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026
cjyuan
cjyuan reviewed Jul 2, 2026
View reviewed changes
Comment threadSprint-2/2-mandatory-debug/0.js Outdated
Comment threadSprint-2/3-mandatory-implement/2-cases.js Outdated
// Use the MDN string documentation to help you find a solution
// This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase

function touppersneakers (input){

@cjyuancjyuanJul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look up the naming conventions in JavaScript? In particular,

  • Variable and function names
  • Class and Types names
  • Named constants

Then, update the function name according to those conventions.

Comment threadSprint-2/3-mandatory-implement/2-cases.js Outdated
Comment threadSprint-2/3-mandatory-implement/3-to-pounds.js Outdated
Comment threadSprint-2/5-stretch-extend/format-time.js Outdated
Comment threadSprint-2/5-stretch-extend/format-time.js Outdated
Comment on lines 18 to 22
if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${hours - 12}:${minutes} pm`;
}

return `${time} am`;

@cjyuancjyuanJul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks correct.

Could you update the code so that the return values of formatAs12HourClock("01:23") and formatAs12HourClock("13:23") are formatted consistently?

@cjyuancjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 2, 2026
@Enice-CodesEnice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 4, 2026
cjyuan
cjyuan reviewed Jul 4, 2026
View reviewed changes

@cjyuancjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes are good.

Comment threadSprint-2/2-mandatory-debug/0.js Outdated
Comment threadSprint-2/3-mandatory-implement/2-cases.js Outdated
Comment threadSprint-2/5-stretch-extend/format-time.js
Comment on lines -13 to +28
const currentOutput = formatAs12HourClock("08:00");
const targetOutput = "08:00 am";
// Existing tests
console.assert(
formatAs12HourClock("8:00") === "8:00 am",
"8:00 should be 8:00 am"
);

@cjyuancjyuanJul 4, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original tests suggest the argument is a string in the form "hh:mm" (2-digit hour and 2-digit minute).

Without changing the argument, to make the return value formatted consistently we could conditionally pad a 0 to the hour so that the return value is in the form "hh:mm am" or "hh:mm pm".

@cjyuancjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 4, 2026
@Enice-CodesEnice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 20, 2026
@Enice-CodesEnice-Codes mentioned this pull request Jul 20, 2026
Closed
@cjyuan

cjyuan commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Changes look good.

@cjyuancjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 23, 2026
@Enice-CodesEnice-Codes mentioned this pull request Aug 2, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuancjyuancjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.Module-Structuring-And-Testing-DataThe name of the module.📅 Sprint 2Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Enice-Codes@cjyuan