Uh oh!
There was an error while loading. Please reload this page.
Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Practice TDD - #1579
Open
KhotKeys wants to merge 5 commits into
Open
Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Practice TDD#1579KhotKeys wants to merge 5 commits into
KhotKeys wants to merge 5 commits into
Conversation
cjyuan
reviewed
Jul 28, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Could you also update get-ordinal-number.test.js?
KhotKeys
commented
Jul 28, 2026
Author
Alright, let me check that out. |
KhotKeys
commented
Jul 28, 2026
Author
Hi @cjyuan, Updated the test file, thanks! |
cjyuan
reviewed
Jul 29, 2026
| }); | ||
| // Case 5: All other numbers | ||
| test("should append 'th' for all other numbers", () => { |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... all other numbers", it may be unclear what "other numbers" actually refers to.
Could you revise the test description to make it more informative?
cjyuan
reviewed
Aug 7, 2026
| // Case 4: Numbers ending with 11, 12, or 13 are special and take "th" | ||
| test("should append 'th' for numbers ending with 11, 12, or 13", () => { | ||
| test("should append 'th' for numbers where (num % 10 === 0, 4-9) or (num % 100 === 11, 12, 13)", () => { |
Contributor
There was a problem hiding this comment.
I think stating "last digit is ..." and "last two digits are ..." are clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist