Skip to content

London | May-2026-itp | Vitalii Kmit | Sprint 3 | Refactor Dead Code - #1584

Open
Vitalii-code wants to merge 4 commits into
CodeYourFuture:mainfrom
Vitalii-code:coursework/sprint-3-dead-code
Open

London | May-2026-itp | Vitalii Kmit | Sprint 3 | Refactor Dead Code#1584
Vitalii-code wants to merge 4 commits into
CodeYourFuture:mainfrom
Vitalii-code:coursework/sprint-3-dead-code

Conversation

@Vitalii-code

@Vitalii-codeVitalii-code commented Jul 29, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Worked on the dead-code part of coursework

@github-actions

This comment has been minimized.

Sign in to view
@Vitalii-codeVitalii-code mentioned this pull request Jul 29, 2026
Open
@Vitalii-codeVitalii-code added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@Vitalii-code

Vitalii-code commented Jul 29, 2026

Copy link
Copy Markdown
Author

I'm pretty sure the bot is wrong, because I only touched exercise-1.js and exercise-2.js

@Vitalii-codeVitalii-code added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@illicitonionillicitonion changed the title London | May-2026-itp | Vitalii Kmit | Sprint 3 | practice Dead CodeLondon | May-2026-itp | Vitalii Kmit | Sprint 3 | Refactor Dead CodeJul 29, 2026
@Vitalii-codeVitalii-code added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 29, 2026
@Luro91Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 30, 2026
Luro91
Luro91 reviewed Jul 30, 2026
View reviewed changes
Comment threadSprint-3/3-dead-code/exercise-1.js Outdated
return greetingStr;
}

let testName = "Jerry";

@Luro91Luro91Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line needed for?

@Vitalii-codeVitalii-codeAug 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not needed.

@Luro91Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 30, 2026
@Vitalii-codeVitalii-code added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 1, 2026
Luro91
Luro91 reviewed Aug 2, 2026
View reviewed changes

@Luro91Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on removing the not needed code

@Luro91Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Luro91Luro91Luro91 left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vitalii-code@Luro91