Skip to content

London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Dead-Code - #1591

Open
russom-g wants to merge 2 commits into
CodeYourFuture:mainfrom
russom-g:Sprint-3/3-dead-code
Open

London | 26-ITP-May | Russom Gebremeskel | Sprint 3 | Dead-Code#1591
russom-g wants to merge 2 commits into
CodeYourFuture:mainfrom
russom-g:Sprint-3/3-dead-code

Conversation

@russom-g

@russom-grussom-g commented Jul 30, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Dead code that was not contributing the the function identified and removed.

@russom-grussom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 30, 2026
LonMcGregor
LonMcGregor reviewed Aug 1, 2026
View reviewed changes

@LonMcGregorLonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprint 3 looks good - but can you remove the unneeded files from Sprint 1? Thanks

@LonMcGregorLonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 1, 2026
@russom-g

russom-g commented Aug 1, 2026

Copy link
Copy Markdown
Author

@LonMcGregor Files that don't belong here are removed.

@LonMcGregorLonMcGregor added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 3, 2026
@LonMcGregor

LonMcGregor commented Aug 3, 2026

Copy link
Copy Markdown

If you check the "files changed" tab here on github, you can see lots of files listed. Can you fix it so only the dead code ones are listed? You may want to check https://curriculum.codeyourfuture.io/guides/reviewing/fixing/ if you need a reminder on how to do this

@LonMcGregorLonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 3, 2026
@russom-g
russom-gforce-pushed the Sprint-3/3-dead-code branch from adb19d8 to 7611916CompareAugust 3, 2026 19:57
@russom-g

russom-g commented Aug 3, 2026

Copy link
Copy Markdown
Author

@LonMcGregor I removed the files. Hopefully it worked this time.

LonMcGregor
LonMcGregor reviewed Aug 4, 2026
View reviewed changes

@LonMcGregorLonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! This is complete now

@LonMcGregorLonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 4, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregorLonMcGregorLonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CompleteVolunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russom-g@LonMcGregor