Uh oh!
There was an error while loading. Please reload this page.
London | 26-SDC-July | AYK| Sprint 3 | Implement shell tools - #612
Open
sarawone wants to merge 3 commits into
Open
London | 26-SDC-July | AYK| Sprint 3 | Implement shell tools#612sarawone wants to merge 3 commits into
sarawone wants to merge 3 commits into
Conversation
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start, but I think there is a lot left to do here
| .name ("cat") | ||
| .description ("A JS clone for unix command cat") | ||
| .argument("<files...>","One or more files to reach and print") | ||
| .option("-n", "number all output lines") |
Contributor
There was a problem hiding this comment.
Good work so far, have you implemented everything the readme asked for?
| .name ("list command clone") | ||
| .description("List all files & folders within current folder") | ||
| .argument("[directory]","Directory to list",".") | ||
| .option("-1","list file line by line") |
Contributor
There was a problem hiding this comment.
Are you correctly handling the -1 option?
have you implemented everything the readme asked for?
| program | ||
| .name("WC clone") | ||
| .description("Counting each words in a given file") | ||
| .argument("<files...>","one or more files to count the words") |
Contributor
There was a problem hiding this comment.
Thinking about arguments and options, have you implemented everything the readme asked for?
| if (files.length>1) | ||
| { | ||
| printCounts({lineCount:totalLines, |
Contributor
There was a problem hiding this comment.
What is the reason for passing an object then destructuring in printCounts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Kindly check the shell tools implementation with JS.
Please provide guidance and feedback on this.
Thanks and Regards,
AYK
Task ID: CYF-1150