Skip to content

NW6 | Fathi Kahin | JS2 | Codewars API project | Week 4 - #14

Open
fhkahin wants to merge 5 commits into
CodeYourFuture:mainfrom
fhkahin:JS2---Codewars-API-project-Week-4
Open

NW6 | Fathi Kahin | JS2 | Codewars API project | Week 4 #14
fhkahin wants to merge 5 commits into
CodeYourFuture:mainfrom
fhkahin:JS2---Codewars-API-project-Week-4

Conversation

@fhkahin

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@netlify

netlifyBot commented Jan 19, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-codewars-projects ready!

NameLink
🔨 Latest commite6cda52
🔍 Latest deploy loghttps://app.netlify.com/sites/cyf-codewars-projects/deploys/65aab249dba67f00075ef346
😎 Deploy Previewhttps://deploy-preview-14--cyf-codewars-projects.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SallyMcGrathSallyMcGrath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start.

Comment threadcodewars-badge.js
${this.userData.ranks.overall.name}
</data>`;
<data>
<table>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this table valid? When you validated your HTML what did you find was missing?

Comment threadindex.html
<body>
<codewars-badge></codewars-badge>
<h1> Fathi's Codewars Data: </h1> <br>
<table>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a table? Is this tabular data?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fhkahin@SallyMcGrath